From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755791AbaGBQEV (ORCPT ); Wed, 2 Jul 2014 12:04:21 -0400 Received: from svenfoo.org ([82.94.215.22]:47135 "EHLO mail.zonque.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435AbaGBQET (ORCPT ); Wed, 2 Jul 2014 12:04:19 -0400 Message-ID: <53B42D7F.60002@zonque.org> Date: Wed, 02 Jul 2014 18:04:15 +0200 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Dan Murphy , linux-sound@vger.kernel.org CC: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier References: <1404307852-10456-1-git-send-email-dmurphy@ti.com> <53B40D55.6000602@zonque.org> <53B41F0E.90107@ti.com> In-Reply-To: <53B41F0E.90107@ti.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2014 05:02 PM, Dan Murphy wrote: > On 07/02/2014 08:47 AM, Daniel Mack wrote: >> Hi Dan, >> >> On 07/02/2014 03:30 PM, Dan Murphy wrote: >>> + if (np) { >>> + data->power_gpio = of_get_named_gpio(np, "enable-gpio", 0); >>> + } else if (pdata) { >>> + data->power_gpio = pdata->enable_gpio; >>> + } else { >>> + dev_err(dev, "Platform or dev tree data not set\n"); >>> + return -ENODEV; >>> + } >> New code for GPIO handling should use the new gpiod interface. >> See include/linux/gpio/consumer.h, or the sta350 codec driver. > > OK good catch. I will look into it. > > Does the gpiod interface handle both pdata as well as dt? Yes, please refer to Documentation/gpio/board.txt. >> For that to work, you also need to rename the property to >> 'enable-gpios', even though there's only one. > > I am looking for that restriction in the code. But don't see it. > Will dig some more here. Ah, dd34c37aa3 ("gpio: of: Allow -gpio suffix for property names") changed that, so both variants are now supported. Daniel