From: Lars-Peter Clausen <lars@metafoo.de>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
vinod.koul@intel.com, dan.j.williams@intel.com, tiwai@suse.de,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
joelf@ti.com, nsekhar@ti.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support
Date: Thu, 03 Jul 2014 10:33:34 +0200 [thread overview]
Message-ID: <53B5155E.7050103@metafoo.de> (raw)
In-Reply-To: <1404363116-10538-1-git-send-email-peter.ujfalusi@ti.com>
On 07/03/2014 06:51 AM, Peter Ujfalusi wrote:
[...]
>
> First step is to add DMA_SLAVE_BUSWIDTH_3_BYTES to dma_slave_buswidth for
> engines and users to select 3 bytes as bus width.
>
> Followed by:
> In dmaengine_pcm_set_runtime_hwparams() we should check the slave_caps of the
> dma if it supports the give sample physical width of the sample. Based on this
> information we initialize the hw.formats: masking out all non supported formats
> based on the physical width.
> In case the dma driver does not implement the slave_caps the default assumption
> is that it supports 1, 2 and 4 bytes widths.
The whole series looks good to me. Since both the DMA and ALSA bits changed
in this series are fairly trivial I think it is best to merge the whole
series through the ASoC tree.
- Lars
next prev parent reply other threads:[~2014-07-03 8:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 4:51 [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support Peter Ujfalusi
2014-07-03 4:51 ` [PATCH v3 1/5] dma: Support for 3 bytes word size Peter Ujfalusi
2014-07-03 4:51 ` [PATCH v3 2/5] ALSA: pcm_dmaengine: Use the available wrapper to get physical width Peter Ujfalusi
2014-07-03 4:51 ` [PATCH v3 3/5] ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical sample sizes Peter Ujfalusi
2014-07-03 8:29 ` Lars-Peter Clausen
2014-07-03 12:01 ` Mark Brown
2014-07-03 12:02 ` Vinod Koul
2014-07-03 13:42 ` Mark Brown
2014-07-03 16:17 ` Vinod Koul
2014-07-03 16:21 ` Mark Brown
2014-07-03 4:51 ` [PATCH v3 4/5] ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths Peter Ujfalusi
2014-07-03 8:29 ` Lars-Peter Clausen
2014-07-03 4:51 ` [PATCH v3 5/5] dma: edma: Declare DMA_SLAVE_BUSWIDTH_3_BYTES as supported buswidth Peter Ujfalusi
2014-07-03 8:33 ` Lars-Peter Clausen [this message]
2014-07-03 9:38 ` [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support Vinod Koul
2014-07-03 12:02 ` Mark Brown
2014-07-04 5:34 ` Takashi Iwai
2014-07-04 17:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B5155E.7050103@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=joelf@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox