From: Yijing Wang <wangyijing@huawei.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
<iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] trivial cleanup for iommu/vt-d
Date: Fri, 4 Jul 2014 17:29:24 +0800 [thread overview]
Message-ID: <53B673F4.1050205@huawei.com> (raw)
In-Reply-To: <20140704092209.GA13434@8bytes.org>
On 2014/7/4 17:22, Joerg Roedel wrote:
> On Tue, May 20, 2014 at 08:37:46PM +0800, Yijing Wang wrote:
>>
>> Yijing Wang (6):
>> iommu/vt-d: Use list_for_each_safe() to simplify code
>> iommu/vt-d: move up no_iommu and dmar_disabled check
>> iommu/vt-d: clear the redundant assignment in dmar_enable_qi
>> iommu/vt-d: clear the redundant assignment for domain->nid
>> iommu/vt-d: use inline function dma_pte_superpage instead of macros
>> iommu/vt-d: fix reference count in iommu_prepare_isa
>
> Applied patches 1, 3, 4, 5 and 6, thanks. Also added another patch
> on-top, see below.
Thanks a lot!
Yijing.
>
>>From 77c704bebc5d023ece7af32ea18bc3508cdb0007 Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <jroedel@suse.de>
> Date: Fri, 4 Jul 2014 11:19:10 +0200
> Subject: [PATCH] iommu/vt-d: Don't use magic number in dma_pte_superpage
>
> Use the already defined DMA_PTE_LARGE_PAGE for testing
> instead of hardcoding the value again.
>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 9b9f28e..5d86e93 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -304,7 +304,7 @@ static inline bool dma_pte_present(struct dma_pte *pte)
>
> static inline bool dma_pte_superpage(struct dma_pte *pte)
> {
> - return (pte->val & (1 << 7));
> + return (pte->val & DMA_PTE_LARGE_PAGE);
> }
>
> static inline int first_pte_in_page(struct dma_pte *pte)
>
--
Thanks!
Yijing
prev parent reply other threads:[~2014-07-04 9:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 12:37 [PATCH 0/6] trivial cleanup for iommu/vt-d Yijing Wang
2014-05-20 12:37 ` [PATCH 1/6] iommu/vt-d: Use list_for_each_safe() to simplify code Yijing Wang
2014-05-20 12:37 ` [PATCH 2/6] iommu/vt-d: move up no_iommu and dmar_disabled check Yijing Wang
2014-07-04 9:06 ` Joerg Roedel
2014-07-04 9:28 ` Yijing Wang
2014-05-20 12:37 ` [PATCH 3/6] iommu/vt-d: clear the redundant assignment in dmar_enable_qi Yijing Wang
2014-05-20 12:37 ` [PATCH 4/6] iommu/vt-d: clear the redundant assignment for domain->nid Yijing Wang
2014-05-20 12:37 ` [PATCH 5/6] iommu/vt-d: use inline function dma_pte_superpage instead of macros Yijing Wang
2014-05-20 12:37 ` [PATCH 6/6] iommu/vt-d: fix reference count in iommu_prepare_isa Yijing Wang
2014-06-18 0:56 ` [PATCH 0/6] trivial cleanup for iommu/vt-d Yijing Wang
2014-07-04 9:22 ` Joerg Roedel
2014-07-04 9:29 ` Yijing Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B673F4.1050205@huawei.com \
--to=wangyijing@huawei.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox