From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [patch]blk-mq: suppress a warning
Date: Fri, 4 Jul 2014 09:35:22 -0600 [thread overview]
Message-ID: <53B6C9BA.1020106@fb.com> (raw)
In-Reply-To: <20140704112623.GA17435@kernel.org>
On 07/04/2014 05:26 AM, Shaohua Li wrote:
>
> The warning is hit when cpu hotplug is running. After scheduler puts a cpu
> online and before blk-mq mapping reinit, a task can queue a request and run the
> queue. At that time the cpu isn't in hctx->cpumask, but the cpu is mapped into
> hctx 0. When the race happens, hctx->cpumask doesn't set the cpu and
> ctx->index_hw/hctx->nr_ctx isn't correct, but it doesn't cause any problem. So
> just suppress the warning here.
Thanks Shaohua, I think that is an improvement. Not super fond of having
to do an extra map, but it's saner than the CPU test in that it uses the
same mechanism to verify it's correct. And we can probably kill this
WARN_ON() in a revision or two.
next prev parent reply other threads:[~2014-07-04 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 11:26 [patch]blk-mq: suppress a warning Shaohua Li
2014-07-04 15:35 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-06 16:04 [patch] blk-mq: " Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B6C9BA.1020106@fb.com \
--to=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).