From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
Grant Likely <grant.likely@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2] platform_get_irq: Revert to platform_get_resource if of_irq_get fails
Date: Fri, 04 Jul 2014 12:51:13 -0700 [thread overview]
Message-ID: <53B705B1.3000403@roeck-us.net> (raw)
In-Reply-To: <20140630162250.GA24179@kroah.com>
On 06/30/2014 09:22 AM, Greg Kroah-Hartman wrote:
> On Mon, Jun 30, 2014 at 09:18:35AM -0700, Guenter Roeck wrote:
>> On Mon, Jun 23, 2014 at 10:48:33AM -0500, Rob Herring wrote:
>>> On Tue, Jun 17, 2014 at 5:51 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>> Commits 9ec36ca (of/irq: do irq resolution in platform_get_irq)
>>>> and ad69674 (of/irq: do irq resolution in platform_get_irq_byname)
>>>> change the semantics of platform_get_irq and platform_get_irq_byname
>>>> to always rely on devicetree information if devicetree is enabled
>>>> and if a devicetree node is attached to the device. The functions
>>>> now return an error if the devicetree data does not include interrupt
>>>> information, even if the information is available as platform resource
>>>> data.
>>>>
>>>> This causes mfd client drivers to fail if the interrupt number is
>>>> passed via platform resources. Therefore, if of_irq_get fails, try
>>>> platform_get_resource as method of last resort. This restores the
>>>> original functionality for drivers depending on platform resources
>>>> to get irq information.
>>>>
>>>> Cc: Russell King <linux@arm.linux.org.uk>
>>>> Cc: Rob Herring <robh@kernel.org>
>>>> Cc: Tony Lindgren <tony@atomide.com>
>>>> Cc: Grant Likely <grant.likely@linaro.org>
>>>> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>>
>>> Greg should take this for 3.16.
>>>
>> Doesn't seem to go anywhere. Guess it's one more patch I'll have to carry
>> locally :-(. If anyone has a better idea how to fix the problem, please
>> let me know.
>
> I can still queue this up, I was hoping that Grant would chime in...
>
Doesn't look like it.
Guenter
prev parent reply other threads:[~2014-07-04 19:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 22:51 [PATCH v2] platform_get_irq: Revert to platform_get_resource if of_irq_get fails Guenter Roeck
2014-06-23 15:33 ` Guenter Roeck
2014-06-23 15:48 ` Rob Herring
2014-06-23 17:12 ` Guenter Roeck
2014-06-30 16:18 ` Guenter Roeck
2014-06-30 16:22 ` Greg Kroah-Hartman
2014-07-04 19:51 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B705B1.3000403@roeck-us.net \
--to=linux@roeck-us.net \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox