From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760060AbaGDTvQ (ORCPT ); Fri, 4 Jul 2014 15:51:16 -0400 Received: from mail.active-venture.com ([67.228.131.205]:51831 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbaGDTvP (ORCPT ); Fri, 4 Jul 2014 15:51:15 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <53B705B1.3000403@roeck-us.net> Date: Fri, 04 Jul 2014 12:51:13 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Rob Herring , "linux-kernel@vger.kernel.org" , Russell King , Tony Lindgren , Grant Likely , Grygorii Strashko Subject: Re: [PATCH v2] platform_get_irq: Revert to platform_get_resource if of_irq_get fails References: <1403045462-24204-1-git-send-email-linux@roeck-us.net> <20140630161835.GA14632@roeck-us.net> <20140630162250.GA24179@kroah.com> In-Reply-To: <20140630162250.GA24179@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30/2014 09:22 AM, Greg Kroah-Hartman wrote: > On Mon, Jun 30, 2014 at 09:18:35AM -0700, Guenter Roeck wrote: >> On Mon, Jun 23, 2014 at 10:48:33AM -0500, Rob Herring wrote: >>> On Tue, Jun 17, 2014 at 5:51 PM, Guenter Roeck wrote: >>>> Commits 9ec36ca (of/irq: do irq resolution in platform_get_irq) >>>> and ad69674 (of/irq: do irq resolution in platform_get_irq_byname) >>>> change the semantics of platform_get_irq and platform_get_irq_byname >>>> to always rely on devicetree information if devicetree is enabled >>>> and if a devicetree node is attached to the device. The functions >>>> now return an error if the devicetree data does not include interrupt >>>> information, even if the information is available as platform resource >>>> data. >>>> >>>> This causes mfd client drivers to fail if the interrupt number is >>>> passed via platform resources. Therefore, if of_irq_get fails, try >>>> platform_get_resource as method of last resort. This restores the >>>> original functionality for drivers depending on platform resources >>>> to get irq information. >>>> >>>> Cc: Russell King >>>> Cc: Rob Herring >>>> Cc: Tony Lindgren >>>> Cc: Grant Likely >>>> Cc: Grygorii Strashko >>>> Signed-off-by: Guenter Roeck >>> >>> Acked-by: Rob Herring >>> >>> Greg should take this for 3.16. >>> >> Doesn't seem to go anywhere. Guess it's one more patch I'll have to carry >> locally :-(. If anyone has a better idea how to fix the problem, please >> let me know. > > I can still queue this up, I was hoping that Grant would chime in... > Doesn't look like it. Guenter