From: Randy Dunlap <rdunlap@infradead.org>
To: Nicholas Krause <xerofoify@gmail.com>, ralf@linux-mips.org
Cc: jchandra@broadcom.com, blogic@openwrt.org,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: Add #ifdef in file bridge.h
Date: Sat, 05 Jul 2014 07:43:08 -0700 [thread overview]
Message-ID: <53B80EFC.6020504@infradead.org> (raw)
In-Reply-To: <1404528619-3715-1-git-send-email-xerofoify@gmail.com>
On 07/04/2014 07:50 PM, Nicholas Krause wrote:
> This patch addes a #ifdef __ASSEMBLY__ in order to check if this part
> of the file is configured to fix this #ifdef block in bridge.h for mips.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/mips/include/asm/netlogic/xlp-hal/bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/netlogic/xlp-hal/bridge.h b/arch/mips/include/asm/netlogic/xlp-hal/bridge.h
> index 3067f98..4f315c3 100644
> --- a/arch/mips/include/asm/netlogic/xlp-hal/bridge.h
> +++ b/arch/mips/include/asm/netlogic/xlp-hal/bridge.h
> @@ -143,7 +143,7 @@
> #define BRIDGE_GIO_WEIGHT 0x2cb
> #define BRIDGE_FLASH_WEIGHT 0x2cc
>
> -/* FIXME verify */
> +#ifdef __ASSEMBLY__
> #define BRIDGE_9XX_FLASH_BAR(i) (0x11 + (i))
> #define BRIDGE_9XX_FLASH_BAR_LIMIT(i) (0x15 + (i))
>
>
Hi,
Where is the corresponding #endif ?
The #endif at line 185 goes with the #ifndef __ASSEMBLY__ at line 176.
I think that this patch will cause a build error (or at least a warning).
Did you test it?
--
~Randy
next prev parent reply other threads:[~2014-07-05 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 2:50 [PATCH] mips: Add #ifdef in file bridge.h Nicholas Krause
2014-07-05 14:43 ` Randy Dunlap [this message]
2014-07-06 5:58 ` Nick Krause
[not found] ` <20140706070814.GA8511@jayachandranc.netlogicmicro.com>
2014-07-07 3:05 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B80EFC.6020504@infradead.org \
--to=rdunlap@infradead.org \
--cc=blogic@openwrt.org \
--cc=jchandra@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox