* [PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA
@ 2014-07-07 8:49 Chen Gang
2014-07-09 18:23 ` Colin Cross
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-07-07 8:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, john.stultz, ccross, rebecca, Liqin Chen,
Lennox Wu
Cc: devel, linux-kernel@vger.kernel.org
ION need HAS_DMA (e.g. need DMA_SHARED_BUFFER), so it has to depend on
HAS_DMA, or can not pass compiling with allmodconfig under score which
NO_DMA. And the related error:
CC drivers/staging/android/ion/ion_cma_heap.o
drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_mmap':
drivers/staging/android/ion/ion_cma_heap.c:168:2: error: implicit declaration of function 'dma_mmap_coherent' [-Werror=implicit-function-declaration]
return dma_mmap_coherent(dev, vma, info->cpu_addr, info->handle,
^
cc1: some warnings being treated as errors
make[4]: *** [drivers/staging/android/ion/ion_cma_heap.o] Error 1
make[3]: *** [drivers/staging/android/ion] Error 2
make[2]: *** [drivers/staging/android] Error 2
make[1]: *** [drivers/staging] Error 2
make: *** [drivers] Error 2
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/staging/android/ion/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
index 0f8fec1..0a6e4d0 100644
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -1,6 +1,6 @@
menuconfig ION
bool "Ion Memory Manager"
- depends on HAVE_MEMBLOCK
+ depends on HAVE_MEMBLOCK && HAS_DMA
select GENERIC_ALLOCATOR
select DMA_SHARED_BUFFER
---help---
--
1.9.2.459.g68773ac
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA
2014-07-07 8:49 [PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA Chen Gang
@ 2014-07-09 18:23 ` Colin Cross
0 siblings, 0 replies; 2+ messages in thread
From: Colin Cross @ 2014-07-09 18:23 UTC (permalink / raw)
To: Chen Gang
Cc: Greg Kroah-Hartman, John Stultz, Rebecca Zavin, Liqin Chen,
Lennox Wu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On Mon, Jul 7, 2014 at 1:49 AM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> ION need HAS_DMA (e.g. need DMA_SHARED_BUFFER), so it has to depend on
> HAS_DMA, or can not pass compiling with allmodconfig under score which
> NO_DMA. And the related error:
>
> CC drivers/staging/android/ion/ion_cma_heap.o
> drivers/staging/android/ion/ion_cma_heap.c: In function 'ion_cma_mmap':
> drivers/staging/android/ion/ion_cma_heap.c:168:2: error: implicit declaration of function 'dma_mmap_coherent' [-Werror=implicit-function-declaration]
> return dma_mmap_coherent(dev, vma, info->cpu_addr, info->handle,
> ^
> cc1: some warnings being treated as errors
> make[4]: *** [drivers/staging/android/ion/ion_cma_heap.o] Error 1
> make[3]: *** [drivers/staging/android/ion] Error 2
> make[2]: *** [drivers/staging/android] Error 2
> make[1]: *** [drivers/staging] Error 2
> make: *** [drivers] Error 2
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/staging/android/ion/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 0f8fec1..0a6e4d0 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -1,6 +1,6 @@
> menuconfig ION
> bool "Ion Memory Manager"
> - depends on HAVE_MEMBLOCK
> + depends on HAVE_MEMBLOCK && HAS_DMA
> select GENERIC_ALLOCATOR
> select DMA_SHARED_BUFFER
> ---help---
> --
> 1.9.2.459.g68773ac
Acked-by: Colin Cross <ccross@android.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-09 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-07 8:49 [PATCH] drivers: staging: android: ion: Kconfig: Let it also depend on HAS_DMA Chen Gang
2014-07-09 18:23 ` Colin Cross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).