From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbaGGPmd (ORCPT ); Mon, 7 Jul 2014 11:42:33 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:58421 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbaGGPma (ORCPT ); Mon, 7 Jul 2014 11:42:30 -0400 Message-ID: <53BABFDE.1000703@gmail.com> Date: Mon, 07 Jul 2014 09:42:22 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Christian Borntraeger , Alexander Yarygin , Jiri Olsa CC: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Cornelia Huck , linux-kernel@vger.kernel.org, Paolo Bonzini Subject: Re: [PATCH 1/4] perf kvm: Use defines of kvm events References: <1404397747-20939-1-git-send-email-yarygin@linux.vnet.ibm.com> <1404397747-20939-2-git-send-email-yarygin@linux.vnet.ibm.com> <53BAA963.2010800@de.ibm.com> In-Reply-To: <53BAA963.2010800@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/7/14, 8:06 AM, Christian Borntraeger wrote: > On 03/07/14 16:29, Alexander Yarygin wrote: >> Currently perf-kvm uses string literals for kvm event names, >> but it works only for x86, because other architectures may have >> other names for those events. >> >> To reduce dependence on architecture, we add file with >> defines for: >> - kvm_entry and kvm_exit events, >> - exit reason field name in kvm_exit event, >> - length of exit reasons strings, >> - vcpu_id field name in kvm trace events, >> >> and replace literals in perf-kvm. >> >> Signed-off-by: Alexander Yarygin >> Reviewed-by: Cornelia Huck > > Acked-by: Christian Borntraeger > Would be good if Paolo and David could ack the KVM/perf parts. Then this should also go into next merge window. I want to try out the patches on x86 and verify compiles on ppc; hopefully by end of day tomorrow. David