From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Graeme Gregory <graeme.gregory@linaro.org>,
Tony Luck <tony.luck@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org
Subject: Re: [PATCH 4/4] ACPI: Make EC debugfs depend on X86 || IA64 in Kconfig
Date: Tue, 08 Jul 2014 17:23:16 +0800 [thread overview]
Message-ID: <53BBB884.5000005@linaro.org> (raw)
In-Reply-To: <200683000.sgUJl2AyWR@vostro.rjw.lan>
On 2014年07月08日 05:16, Rafael J. Wysocki wrote:
> On Wednesday, July 02, 2014 04:47:26 PM Hanjun Guo wrote:
>> Since EC (Embedded controller) needs SCI for the interupt which
>> is not available on ARM64, make the EC debugfs depend on X86 || IA64
>> only in the Kconfig file.
>>
>> Reviewed-by: Grant Likely <grant.likely@linaro.org>
>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> ---
>> drivers/acpi/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
>> index 0e6f72d..7de5e3f 100644
>> --- a/drivers/acpi/Kconfig
>> +++ b/drivers/acpi/Kconfig
>> @@ -69,6 +69,7 @@ config ACPI_PROCFS_POWER
>>
>> config ACPI_EC_DEBUGFS
>> tristate "EC read/write access through /sys/kernel/debug/ec"
>> + depends on X86 || IA64
> This is totally inconsistent with the other patches in the series where you
> define per-arch symbols for similar things. In addition to that, do we need
> to build ec.c on ARM at all?
Yes, EC will be needed on ARM. This patch is not needed after some more
consideration, I will drop it.
Thanks
Hanjun
prev parent reply other threads:[~2014-07-08 9:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 8:47 [PATCH 0/4] Clean up ACPI core to prepare for running ACPI on ARM64 Hanjun Guo
2014-07-02 8:47 ` [PATCH 1/4] ACPI: ARM64 does not have a BIOS add config for BIOS table scan Hanjun Guo
2014-07-07 21:06 ` Rafael J. Wysocki
2014-07-08 9:55 ` Hanjun Guo
2014-07-02 8:47 ` [PATCH 2/4] ACPI: Don't use acpi_lapic in ACPI core code Hanjun Guo
2014-07-07 21:08 ` Rafael J. Wysocki
2014-07-08 10:07 ` Hanjun Guo
2014-07-02 8:47 ` [PATCH 3/4] ACPI / processor: Introduce ARCH_HAS_ACPI_PDC Hanjun Guo
2014-07-07 21:13 ` Rafael J. Wysocki
2014-07-08 9:58 ` Hanjun Guo
2014-07-02 8:47 ` [PATCH 4/4] ACPI: Make EC debugfs depend on X86 || IA64 in Kconfig Hanjun Guo
2014-07-07 21:16 ` Rafael J. Wysocki
2014-07-08 9:23 ` Hanjun Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BBB884.5000005@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=graeme.gregory@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox