linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM
@ 2014-07-08 12:39 Chen Gang
  2014-07-21 14:45 ` Daniel Lezcano
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-07-08 12:39 UTC (permalink / raw)
  To: daniel.lezcano, tglx; +Cc: linux-kernel@vger.kernel.org, Liqin Chen, Lennox Wu

In 'em_sti.c', it will call devm_ioremap_resource() which need
HAS_IOMEM. So need let EM_TIMER_STI depend on HAS_IOMEM, too.

The related error (with allmodconfig under score):

  LD      init/built-in.o
em_sti.c:(.text.em_sti_probe+0x84): undefined reference to `devm_ioremap_resource'
make: *** [vmlinux] Error 1


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 8ad1eac..ce372d6 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -190,7 +190,7 @@ config SH_TIMER_TMU
 
 config EM_TIMER_STI
 	bool "Renesas STI timer driver" if COMPILE_TEST
-	depends on GENERIC_CLOCKEVENTS
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
 	default SYS_SUPPORTS_EM_STI
 	help
 	  This enables build of a clocksource and clockevent driver for
-- 
1.9.2.459.g68773ac

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM
  2014-07-08 12:39 [PATCH] drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM Chen Gang
@ 2014-07-21 14:45 ` Daniel Lezcano
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2014-07-21 14:45 UTC (permalink / raw)
  To: Chen Gang, tglx; +Cc: linux-kernel@vger.kernel.org, Liqin Chen, Lennox Wu

On 07/08/2014 02:39 PM, Chen Gang wrote:
> In 'em_sti.c', it will call devm_ioremap_resource() which need
> HAS_IOMEM. So need let EM_TIMER_STI depend on HAS_IOMEM, too.
>
> The related error (with allmodconfig under score):
>
>    LD      init/built-in.o
> em_sti.c:(.text.em_sti_probe+0x84): undefined reference to `devm_ioremap_resource'
> make: *** [vmlinux] Error 1
>
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>   drivers/clocksource/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 8ad1eac..ce372d6 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -190,7 +190,7 @@ config SH_TIMER_TMU
>
>   config EM_TIMER_STI
>   	bool "Renesas STI timer driver" if COMPILE_TEST
> -	depends on GENERIC_CLOCKEVENTS
> +	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
>   	default SYS_SUPPORTS_EM_STI
>   	help
>   	  This enables build of a clocksource and clockevent driver for


Applied to my tree for 3.17

Thanks

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-21 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-08 12:39 [PATCH] drivers: clocksource: Kconfig: Let EM_TIMER_STI depend on HAS_IOMEM Chen Gang
2014-07-21 14:45 ` Daniel Lezcano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).