From: Antti Palosaari <crope@iki.fi>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] dvb-frontends: remove unnecessary break after goto
Date: Tue, 08 Jul 2014 21:35:58 +0300 [thread overview]
Message-ID: <53BC3A0E.4060505@iki.fi> (raw)
In-Reply-To: <1404840181-29822-1-git-send-email-fabf@skynet.be>
Moikka Fabian!
I have no reason to decline that patch (I will apply it) even it has
hardly meaning. But is there now some new tool which warns that kind of
issues?
regards
Atnti
On 07/08/2014 08:23 PM, Fabian Frederick wrote:
> Cc: Antti Palosaari <crope@iki.fi>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/media/dvb-frontends/af9013.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c
> index fb504f1..ecf6388 100644
> --- a/drivers/media/dvb-frontends/af9013.c
> +++ b/drivers/media/dvb-frontends/af9013.c
> @@ -470,7 +470,6 @@ static int af9013_statistics_snr_result(struct dvb_frontend *fe)
> break;
> default:
> goto err;
> - break;
> }
>
> for (i = 0; i < len; i++) {
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-07-08 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 17:23 [PATCH 1/1] dvb-frontends: remove unnecessary break after goto Fabian Frederick
2014-07-08 18:35 ` Antti Palosaari [this message]
2014-07-09 2:12 ` Fabian Frederick
2014-07-08 19:57 ` [PATCH] checkpatch: Warn on break after goto or return with same tab indentation Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC3A0E.4060505@iki.fi \
--to=crope@iki.fi \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox