Re: [PATCH 3.2 099/125] mm: fix crashes from mbind() merging vmas

Ben Hutchings
2014-07-09T01:54:16Z

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

On Tue, 2014-07-08 at 14:26 -0700, Hugh Dickins wrote:
> On Tue, 8 Jul 2014, Hugh Dickins wrote:
> > On Tue, 8 Jul 2014, Ben Hutchings wrote:
> >
> > > 3.2.61-rc1 review patch. If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Hugh Dickins <hughd@google.com>
> > >
> > > commit d05f0cdcbe6388723f1900c549b4850360545201 upstream.
> >
> > I don't think that's correct, I can't see a change to the
> > "vma = check_range(" in migrate_to_node() which 3.2 and 3.4 trees have.
> > Does it build (without warning) with CONFIG_NUMA and CONFIG_MIGRATION?
> > I expect this version I sent yesterday for 3.4.98 will be good for 3.2:
>
> Hah, I now see that 098/125 in your series

Which, for anyone who missed it, was commit 082708072a42, 'mm: revert
0def08e3 ("mm/mempolicy.c: check return code of check_range")'.

> removes precisely the "vma = "
> I was calling attention to. So all should be okay and you can ignore me.

Right - of course I'm assuming that the reasoning given for that revert
is valid for 3.2.

Ben.

--
Ben Hutchings
All the simple programs have been written, and all the good names taken.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]