From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755242AbaGIJAF (ORCPT ); Wed, 9 Jul 2014 05:00:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39177 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbaGIJAB (ORCPT ); Wed, 9 Jul 2014 05:00:01 -0400 Message-ID: <53BD048F.4000800@suse.cz> Date: Wed, 09 Jul 2014 10:59:59 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Masahiro Yamada CC: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Ravnborg Subject: Re: [PATCH] kbuild: Use symbolic link to the source tree for out-of-tree build References: <1404887241-14455-1-git-send-email-yamada.m@jp.panasonic.com> In-Reply-To: <1404887241-14455-1-git-send-email-yamada.m@jp.panasonic.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-07-09 08:27, Masahiro Yamada wrote: > Since commit 9da0763bd, the variable 'srctree' is set as follows: > > [1] Building in the source tree > => srctree is set to '.' > [2] Building in a subdir right under the source tree > => srctree is set to '..' > [3] Other cases > => srctree is set to the absolute path to the source tree > > Pros are more readable compiler messages, WARN_ON() etc. > for case [1] and [2]. (but not [3]) > > Cons are we have to do build-test for 3 cases when adding > some changes to the build infrastructure. > > We want to treat case [2] and [3] in the same way like prior to > commit 9da0763bd, keeping the compact log messages. > > The idea here is to create a symbolic link 'srctree' pointing > to $(KBUILD_SRC) at the very early stage of the build process. If the symlink points to an absolute path, then you can't move the source and build tree around anymore. Michal