Re: [PATCH v2] hyperv: Add netpoll support

Richard Weinberger
2014-07-09T14:24:55Z

Am 09.07.2014 16:13, schrieb Sergei Shtylyov:
> Hello.
>
> On 07/09/2014 11:58 AM, Richard Weinberger wrote:
>
>> In order to have at least a netconsole to debug kernel issues on
>> Windows Azure this patch implements netpoll support.
>> Sending packets is easy, netvsc_start_xmit() does already everything
>> needed.
>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/net/hyperv/netvsc_drv.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
>> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
>> index 4fd71b7..45218d5 100644
>> --- a/drivers/net/hyperv/netvsc_drv.c
>> +++ b/drivers/net/hyperv/netvsc_drv.c
>> @@ -736,6 +736,14 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
>> return err;
>> }
>>
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void netvsc_poll_controller(struct net_device *net)
>> +{
>> + /* As netvsc_start_xmit() works synchronous we don't have to
>> + trigger anything here. */
>
> The multi-line comment style in the networking code is this:
>
> /* bla
> * bla
> */
>
>> + return;
>
> Not needed.
>
>> +}
>> +#endif
> [...]

-ETOOMANYCODINGSTYLES :)

Thanks,
//richard