public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michalis Pappas <mpappas@fastmail.fm>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] staging: gdm72xx: move T_CAPABILITY definitions to hci.h
Date: Wed, 09 Jul 2014 19:24:05 +0100	[thread overview]
Message-ID: <53BD88C5.90606@fastmail.fm> (raw)
In-Reply-To: <20140709102603.GV25880@mwanda>

On 07/09/2014 11:26 AM, Dan Carpenter wrote:
>>  	/* GetInformation mac address */
>>  	len = 0;
>> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device *dev)
>>  	hci->length = H2B(len);
>>  	gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len);
>>  
>> -	val = (1<<BIT_WIMAX) | (1<<BIT_MULTI_CS);
>> +	val = (1 << T_CAPABILITY_WIMAX) | (1 << T_CAPABILITY_MULTI_CS);
> 
> Double shifting here...  It should just be:
> 
> 	val = T_CAPABILITY_WIMAX | T_CAPABILITY_MULTI_CS;
> 

Ooops! Thanks for spotting that, will submit a corrected patch.

M.

  reply	other threads:[~2014-07-09 18:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 13:00 [PATCH] staging: gdm72xx: remove unused code Michalis Pappas
2014-07-01 13:00 ` [PATCH] staging: gdm72xx: conditionally compile debug code Michalis Pappas
     [not found]   ` <CAC5Y2nPGyByqLEM1Go6Pxpb6MhiJy2Fvu=eEz6ak24gMhayk=A@mail.gmail.com>
2014-07-01 16:40     ` Michalis Pappas
     [not found]       ` <CAC5Y2nOvJ2=u7-T53kHd50AfQ7Mo_U4qvD_=si9=NSr_q0w3NA@mail.gmail.com>
2014-07-03 17:27         ` Michalis Pappas
2014-07-09 18:51   ` Greg KH
2014-07-09 19:52     ` Michalis Pappas
2014-07-09 20:24       ` Greg KH
2014-07-16 20:40     ` Michalis Pappas
2014-07-16 20:50       ` Greg KH
2014-07-16 22:03         ` Michalis Pappas
2014-07-16 22:10           ` Greg KH
2014-07-16 22:46             ` Joe Perches
2014-07-16 22:57               ` Greg KH
2014-07-17  0:19                 ` Joe Perches
2014-07-01 13:00 ` [PATCH] staging: gdm72xx: move T_CAPABILITY bit definitions to hci.h Michalis Pappas
2014-07-01 15:37   ` Ben Chan
2014-07-01 16:25     ` Michalis Pappas
2014-07-02 10:18   ` [PATCH V2] staging: gdm72xx: move T_CAPABILITY " Michalis Pappas
2014-07-09 10:26     ` Dan Carpenter
2014-07-09 18:24       ` Michalis Pappas [this message]
2014-07-09 18:31         ` [PATCH v3] " Michalis Pappas
2014-07-09 18:57           ` Greg KH
2014-07-09 19:21             ` [PATCH v4] " Michalis Pappas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BD88C5.90606@fastmail.fm \
    --to=mpappas@fastmail.fm \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox