* [PATCH] compal-laptop: correct invalid hwmon name
@ 2014-07-09 19:12 Roald Frederickx
2014-07-09 20:26 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Roald Frederickx @ 2014-07-09 19:12 UTC (permalink / raw)
To: platform-driver-x86; +Cc: linux-kernel
From: Roald Frederickx <roald.frederickx@gmail.com>
Change the name of the hwmon interface from "compal-laptop" to "compal".
A dash is an invalid character for a hwmon name and caused the call to
hwmon_device_register_with_groups() to fail.
Signed-off-by: Roald Frederickx <roald.frederickx@gmail.com>
---
diff --git a/drivers/platform/x86/compal-laptop.c
b/drivers/platform/x86/compal-laptop.c
index 7297df2..26bfd7b 100644
--- a/drivers/platform/x86/compal-laptop.c
+++ b/drivers/platform/x86/compal-laptop.c
@@ -1028,7 +1028,7 @@ static int compal_probe(struct platform_device *pdev)
return err;
hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,
- DRIVER_NAME, data,
+ "compal", data,
compal_hwmon_groups);
if (IS_ERR(hwmon_dev)) {
err = PTR_ERR(hwmon_dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] compal-laptop: correct invalid hwmon name
2014-07-09 19:12 [PATCH] compal-laptop: correct invalid hwmon name Roald Frederickx
@ 2014-07-09 20:26 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2014-07-09 20:26 UTC (permalink / raw)
To: Roald Frederickx; +Cc: platform-driver-x86, linux-kernel
On Wed, Jul 09, 2014 at 09:12:42PM +0200, Roald Frederickx wrote:
> From: Roald Frederickx <roald.frederickx@gmail.com>
>
> Change the name of the hwmon interface from "compal-laptop" to
> "compal". A dash is an invalid character for a hwmon name and caused
> the call to hwmon_device_register_with_groups() to fail.
>
> Signed-off-by: Roald Frederickx <roald.frederickx@gmail.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> diff --git a/drivers/platform/x86/compal-laptop.c
> b/drivers/platform/x86/compal-laptop.c
> index 7297df2..26bfd7b 100644
> --- a/drivers/platform/x86/compal-laptop.c
> +++ b/drivers/platform/x86/compal-laptop.c
> @@ -1028,7 +1028,7 @@ static int compal_probe(struct platform_device *pdev)
> return err;
>
> hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,
> - DRIVER_NAME, data,
> + "compal", data,
> compal_hwmon_groups);
> if (IS_ERR(hwmon_dev)) {
> err = PTR_ERR(hwmon_dev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-09 20:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-09 19:12 [PATCH] compal-laptop: correct invalid hwmon name Roald Frederickx
2014-07-09 20:26 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox