From: Tomasz Figa <tomasz.figa@gmail.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Mike Turquette <mturquette@linaro.org>,
rabin@rab.in, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: Re: [RFC v2 0/5] Per-user clock constraints
Date: Wed, 09 Jul 2014 22:16:29 +0200 [thread overview]
Message-ID: <53BDA31D.40502@gmail.com> (raw)
In-Reply-To: <1404398323-18934-1-git-send-email-tomeu.vizoso@collabora.com>
Hi Tomeu,
On 03.07.2014 16:38, Tomeu Vizoso wrote:
> Hello,
>
> here is another round for commenting, not very different from the first one.
>
> Something I forgot to mention before is that the function rename was performed
> by the scripts in:
>
> http://cgit.collabora.com/git/user/tomeu/linux.git/commit/?h=clk-refactoring-4&id=0e983e28864229f2cd525f87d59e034c4876b233
>
> As before, I have only checked that drivers/clk/ builds with allyesconfig, and
> that a kernel can be built for tegra_defconfig.
This is quite an interesting series. I have reviewed two of five patches
and have plans to look at remaining ones, however here are few general
issues I'd like to raise:
- somehow I don't see patch 2/5 on LAKML. Too big?
- I see the series changing particular clock drivers. A good practice
would be to Cc respective driver maintainers to take a look at those
changes.
- please make sure that all the patches don't have checkpatch errors or
significant warnings.
Will try (myself or by asking someone else) to do some testing on
Samsung platforms.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-09 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 14:38 [RFC v2 0/5] Per-user clock constraints Tomeu Vizoso
2014-07-03 14:38 ` [RFC v2 1/5] clk: Add temporary mapping to the existing API Tomeu Vizoso
2014-07-03 14:38 ` [RFC v2 2/5] clk: Move all drivers to use internal API Tomeu Vizoso
2014-07-03 14:38 ` [RFC v2 3/5] clk: use struct clk only for external API Tomeu Vizoso
2014-07-09 19:27 ` Tomasz Figa
2014-07-10 9:13 ` Tomeu Vizoso
2014-07-09 20:12 ` Tomasz Figa
2014-07-10 9:16 ` Tomeu Vizoso
2014-07-03 14:38 ` [RFC v2 4/5] clk: per-user clock accounting for debug Tomeu Vizoso
2014-07-09 20:01 ` Tomasz Figa
2014-07-10 10:51 ` Tomeu Vizoso
2014-07-03 14:38 ` [RFC v2 5/5] clk: Add floor and ceiling constraints to clock rates Tomeu Vizoso
2014-07-09 20:16 ` Tomasz Figa [this message]
2014-07-10 8:00 ` [RFC v2 0/5] Per-user clock constraints Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDA31D.40502@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=rabin@rab.in \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox