Re: [PATCH 3/8] phy: phy-samsung-usb2: Change phy power on/power off sequence

[Kishon Vijay Abraham I <kishon@ti.com>]

On Thursday 10 July 2014 03:06 AM, Greg KH wrote:
> On Tue, Jul 08, 2014 at 11:42:42AM +0530, Kishon Vijay Abraham I wrote:
>> Hi Greg,
>>
>> On Tuesday 08 July 2014 07:14 AM, Greg KH wrote:
>>> On Mon, Jul 07, 2014 at 12:18:20PM +0530, Kishon Vijay Abraham I wrote:
>>>> From: Kamil Debski <k.debski@samsung.com>
>>>>
>>>> The Exynos4412 USB 2.0 PHY hardware differs from the description provided
>>>> in the documentation. Some register bits have different function. This
>>>> patch fixes the defines of register bits and changes the way how phys are
>>>> powered on and off.
>>>>
>>>> Signed-off-by: Kamil Debski <k.debski@samsung.com>
>>>> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>>> Tested-by: Daniel Drake <drake@endlessm.com>
>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>> ---
>>>>  drivers/phy/phy-exynos4x12-usb2.c |  112 +++++++++++++++++++++++++------------
>>>>  drivers/phy/phy-exynos5250-usb2.c |    2 -
>>>>  drivers/phy/phy-samsung-usb2.h    |    3 +-
>>>>  3 files changed, 77 insertions(+), 40 deletions(-)
>>>>
>>>
>>> This doesn't look like a regression fix for 3.16-final, it looks like a
>>> "new feature" to me :(
>>
>> This patch was primarily due to the incorrectly documented register bits in the
>> manual. So thought this would qualify as fix and should be in 3.16.
> 
> Sorry, that's really big for a patch so late in the -rc cycle.  There
> should only be real regressions or reported bugfixes now.

Okay sure. Will send it.

Thanks
Kishon