From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751113AbaGJFss (ORCPT ); Thu, 10 Jul 2014 01:48:48 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:37640 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbaGJFsr (ORCPT ); Thu, 10 Jul 2014 01:48:47 -0400 Message-ID: <53BE292D.2080104@ti.com> Date: Thu, 10 Jul 2014 11:18:29 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Greg KH CC: Subject: Re: [PATCH 3/8] phy: phy-samsung-usb2: Change phy power on/power off sequence References: <1404715705-5041-1-git-send-email-kishon@ti.com> <1404715705-5041-4-git-send-email-kishon@ti.com> <20140708014442.GB13844@kroah.com> <53BB8BDA.3020205@ti.com> <20140709213624.GA14556@kroah.com> In-Reply-To: <20140709213624.GA14556@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 July 2014 03:06 AM, Greg KH wrote: > On Tue, Jul 08, 2014 at 11:42:42AM +0530, Kishon Vijay Abraham I wrote: >> Hi Greg, >> >> On Tuesday 08 July 2014 07:14 AM, Greg KH wrote: >>> On Mon, Jul 07, 2014 at 12:18:20PM +0530, Kishon Vijay Abraham I wrote: >>>> From: Kamil Debski >>>> >>>> The Exynos4412 USB 2.0 PHY hardware differs from the description provided >>>> in the documentation. Some register bits have different function. This >>>> patch fixes the defines of register bits and changes the way how phys are >>>> powered on and off. >>>> >>>> Signed-off-by: Kamil Debski >>>> Tested-by: Marek Szyprowski >>>> Tested-by: Daniel Drake >>>> Signed-off-by: Kishon Vijay Abraham I >>>> --- >>>> drivers/phy/phy-exynos4x12-usb2.c | 112 +++++++++++++++++++++++++------------ >>>> drivers/phy/phy-exynos5250-usb2.c | 2 - >>>> drivers/phy/phy-samsung-usb2.h | 3 +- >>>> 3 files changed, 77 insertions(+), 40 deletions(-) >>>> >>> >>> This doesn't look like a regression fix for 3.16-final, it looks like a >>> "new feature" to me :( >> >> This patch was primarily due to the incorrectly documented register bits in the >> manual. So thought this would qualify as fix and should be in 3.16. > > Sorry, that's really big for a patch so late in the -rc cycle. There > should only be real regressions or reported bugfixes now. Okay sure. Will send it. Thanks Kishon