From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [PATCH] drbd: fix regression 'out of mem, failed to invoke fence-peer helper'
Date: Thu, 10 Jul 2014 11:55:58 +0200 [thread overview]
Message-ID: <53BE632E.5040408@kernel.dk> (raw)
In-Reply-To: <2397073.C8BSPuutsL@fat-tyre>
On 2014-07-10 11:53, Philipp Reisner wrote:
> Am Donnerstag, 10. Juli 2014, 11:07:22 schrieb Jens Axboe:
>> On 2014-07-09 21:18, Philipp Reisner wrote:
>>> From: Lars Ellenberg <lars.ellenberg@linbit.com>
>>>
>>> Since linux kernel 3.13, kthread_run() internally uses
>>> wait_for_completion_killable(). We sometimes may use kthread_run()
>>> while we still have a signal pending, which we used to kick our threads
>>> out of potentially blocking network functions, causing kthread_run() to
>>> mistake that as a new fatal signal and fail.
>>>
>>> Fix: flush_signals() before kthread_run().
>>
>> Applied - should this have been marked stable, if it affects 3..13+ kernels?
>
> Yes, you are right. It should go to the stable kernels since 3.13 as
> well.
Alright, we'll have to notify Greg/stable when it goes in.
> What is the correct way for me to mark it as stable when sending a patch?
You just add a:
Cc: stable@kernel.org
where the signed-off-by is. If you know the versions it should be
applied to, you can add that information as well. For this case, you
would have done:
Cc: stable@kernel.org # v3.13+
to get it into 3.13 stable and later.
--
Jens Axboe
prev parent reply other threads:[~2014-07-10 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 19:18 [PATCH] Fix DRBD regression Philipp Reisner
2014-07-09 19:18 ` [PATCH] drbd: fix regression 'out of mem, failed to invoke fence-peer helper' Philipp Reisner
2014-07-10 9:07 ` Jens Axboe
2014-07-10 9:53 ` Philipp Reisner
2014-07-10 9:55 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE632E.5040408@kernel.dk \
--to=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox