Re: [PATCH 01/13] clk: tegra: Add binding for the Tegra124 DFLL clocksource

Thierry Reding
2014-07-16T08:01:50Z

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On Tue, Jul 15, 2014 at 11:52:52PM +0100, Mark Brown wrote:
> On Tue, Jul 15, 2014 at 11:23:39PM +0300, Tuomas Tynkkynen wrote:
>
> > That sounds indeed useful for this case. How'd the following interface
> > sound for the register offset / selector-to-register-value conversion?
> > The I2C address would be a bit trickier to get as it would touch the
> > regmap stuff as well, but perhaps it would be a good idea to have a
> > phandle to the I2C device itself, and then parse the reg field for
> > the address.
>
> This looks fine, can you submit properly please? For the I2C address
> why not just have an interface to get the regmap and then provide a way
> to get the underlying device back from the regmap?

Is it mandatory for regulators to use regmap? Also I'm not sure how this
will work with MFDs, since the device may not be the actual bus device,
but rather a child of the MFD (and what we want access to is the MFD).
Perhaps for regmaps that would work in most cases since MFDs seem to
aften share the regmap with their children. However, the code in
regulator_register() at least indicates that even then it's possible to
have a regmap in children that's different from the top-level MFD.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]