* [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master()
@ 2014-06-17 8:25 Liu Ying
2014-07-12 0:58 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Liu Ying @ 2014-06-17 8:25 UTC (permalink / raw)
To: linux-kernel; +Cc: rmk+kernel, gregkh
Remove redundant return value settings 'ret = 0;' in the function
try_to_bring_up_master(), since it has already been set to zero.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
drivers/base/component.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/base/component.c b/drivers/base/component.c
index c477899..007600e 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -123,13 +123,11 @@ static int try_to_bring_up_master(struct master *master,
if (master->ops->add_components(master->dev, master)) {
/* Failed to find all components */
master_remove_components(master);
- ret = 0;
goto out;
}
if (component && component->master != master) {
master_remove_components(master);
- ret = 0;
goto out;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master()
2014-06-17 8:25 [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master() Liu Ying
@ 2014-07-12 0:58 ` Greg KH
2014-07-14 2:17 ` Liu Ying
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2014-07-12 0:58 UTC (permalink / raw)
To: Liu Ying; +Cc: linux-kernel, rmk+kernel
On Tue, Jun 17, 2014 at 04:25:31PM +0800, Liu Ying wrote:
> Remove redundant return value settings 'ret = 0;' in the function
> try_to_bring_up_master(), since it has already been set to zero.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> drivers/base/component.c | 2 --
> 1 file changed, 2 deletions(-)
This patch no longer applies to my tree, are you sure it's still needed?
If so, please refresh and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master()
2014-07-12 0:58 ` Greg KH
@ 2014-07-14 2:17 ` Liu Ying
0 siblings, 0 replies; 3+ messages in thread
From: Liu Ying @ 2014-07-14 2:17 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, rmk+kernel
On 07/12/2014 08:58 AM, Greg KH wrote:
> On Tue, Jun 17, 2014 at 04:25:31PM +0800, Liu Ying wrote:
>> Remove redundant return value settings 'ret = 0;' in the function
>> try_to_bring_up_master(), since it has already been set to zero.
>>
>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>> ---
>> drivers/base/component.c | 2 --
>> 1 file changed, 2 deletions(-)
>
> This patch no longer applies to my tree, are you sure it's still needed?
It is no longer needed, because Russell's patch[1] on your tree changed
this piece of code.
[1]
https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git/commit/drivers/base/component.c?h=driver-core-next&id=c334940ea26cb58f5514dcbb225a3f397b2684ad
Regards,
Liu Ying
>
> If so, please refresh and resend.
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-14 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-17 8:25 [PATCH] drivers/base: redundant return value settings in try_to_bring_up_master() Liu Ying
2014-07-12 0:58 ` Greg KH
2014-07-14 2:17 ` Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox