* [PATCH 1/1] script/kconfig: remove a warning for menucofig
@ 2014-06-30 3:16 Li, Zhen-Hua
2014-06-30 17:02 ` Heinrich Schuchardt
0 siblings, 1 reply; 6+ messages in thread
From: Li, Zhen-Hua @ 2014-06-30 3:16 UTC (permalink / raw)
To: Yann E. MORIN, linux-kbuild, linux-kernel; +Cc: Li, Zhen-Hua
There is a warning when run "make menuconfig".
scripts/kconfig/menu.c: In function ‘get_symbol_str’:
scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
jump->offset = strlen(r->s);
^
scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
struct jump_key *jump;
^
It is because the compiler think "jump" is not initialized, though in fact
it is already initialized.
Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index a26cc5d..584e0fc 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
{
int i, j;
struct menu *submenu[8], *menu, *location = NULL;
- struct jump_key *jump;
+ struct jump_key *jump = NULL;
str_printf(r, _("Prompt: %s\n"), _(prop->text));
menu = prop->menu->parent;
--
2.0.0-rc0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
2014-06-30 3:16 [PATCH 1/1] script/kconfig: remove a warning for menucofig Li, Zhen-Hua
@ 2014-06-30 17:02 ` Heinrich Schuchardt
2014-06-30 23:10 ` Li, Zhen-Hua
2014-07-14 6:25 ` Li, ZhenHua
0 siblings, 2 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2014-06-30 17:02 UTC (permalink / raw)
To: Li, Zhen-Hua, Yann E. MORIN, linux-kbuild, linux-kernel
On 30.06.2014 05:16, Li, Zhen-Hua wrote:
> There is a warning when run "make menuconfig".
>
> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> jump->offset = strlen(r->s);
> ^
> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
> struct jump_key *jump;
> ^
>
> It is because the compiler think "jump" is not initialized, though in fact
> it is already initialized.
>
> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
> ---
> scripts/kconfig/menu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index a26cc5d..584e0fc 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
> {
> int i, j;
> struct menu *submenu[8], *menu, *location = NULL;
> - struct jump_key *jump;
> + struct jump_key *jump = NULL;
>
> str_printf(r, _("Prompt: %s\n"), _(prop->text));
> menu = prop->menu->parent;
>
Hello Zhen-Hua,
the patch looks incomplete to me. A check
jump != NULL
should be added before accessing parts of structure jump_key.
Best regards
Heinrich Schuchardt
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 1/1] script/kconfig: remove a warning for menucofig
2014-06-30 17:02 ` Heinrich Schuchardt
@ 2014-06-30 23:10 ` Li, Zhen-Hua
2014-07-14 16:30 ` Heinrich Schuchardt
2014-07-14 6:25 ` Li, ZhenHua
1 sibling, 1 reply; 6+ messages in thread
From: Li, Zhen-Hua @ 2014-06-30 23:10 UTC (permalink / raw)
To: Heinrich Schuchardt, Yann E. MORIN, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2060 bytes --]
When malloc for jump,
if (head && location) {
jump = xmalloc(sizeof(struct jump_key));
....
}
And here it is used:
if (head && location && menu == location)
jump->offset = strlen(r->s);
So I think when jump is used, it must not be NULL; then !=NULL is not needed.
-----Original Message-----
From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de]
Sent: Tuesday, July 01, 2014 1:03 AM
To: Li, Zhen-Hua; Yann E. MORIN; linux-kbuild@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
On 30.06.2014 05:16, Li, Zhen-Hua wrote:
> There is a warning when run "make menuconfig".
>
> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
> jump->offset = strlen(r->s);
> ^
> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
> struct jump_key *jump;
> ^
>
> It is because the compiler think "jump" is not initialized, though in fact
> it is already initialized.
>
> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
> ---
> scripts/kconfig/menu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index a26cc5d..584e0fc 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
> {
> int i, j;
> struct menu *submenu[8], *menu, *location = NULL;
> - struct jump_key *jump;
> + struct jump_key *jump = NULL;
>
> str_printf(r, _("Prompt: %s\n"), _(prop->text));
> menu = prop->menu->parent;
>
Hello Zhen-Hua,
the patch looks incomplete to me. A check
jump != NULL
should be added before accessing parts of structure jump_key.
Best regards
Heinrich Schuchardt
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
2014-06-30 23:10 ` Li, Zhen-Hua
@ 2014-07-14 16:30 ` Heinrich Schuchardt
2014-07-15 8:53 ` Li, ZhenHua
0 siblings, 1 reply; 6+ messages in thread
From: Heinrich Schuchardt @ 2014-07-14 16:30 UTC (permalink / raw)
To: Li, Zhen-Hua, Yann E. MORIN, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
On 01.07.2014 01:10, Li, Zhen-Hua wrote:
> When malloc for jump,
> if (head && location) {
> jump = xmalloc(sizeof(struct jump_key));
> ....
> }
> And here it is used:
> if (head && location && menu == location)
> jump->offset = strlen(r->s);
>
>
> So I think when jump is used, it must not be NULL; then !=NULL is not needed.
I tested the patch against v13.6-rc5. It fixes the problem with the warning.
You can add
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Best regards
Heinrich
> -----Original Message-----
> From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de]
> Sent: Tuesday, July 01, 2014 1:03 AM
> To: Li, Zhen-Hua; Yann E. MORIN; linux-kbuild@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
>
> On 30.06.2014 05:16, Li, Zhen-Hua wrote:
>> There is a warning when run "make menuconfig".
>>
>> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
>> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used uninitialized in
>> this function [-Wmaybe-uninitialized]
>> jump->offset = strlen(r->s);
>> ^
>> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
>> struct jump_key *jump;
>> ^
>>
>> It is because the compiler think "jump" is not initialized, though in fact
>> it is already initialized.
>>
>> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
>> ---
>> scripts/kconfig/menu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
>> index a26cc5d..584e0fc 100644
>> --- a/scripts/kconfig/menu.c
>> +++ b/scripts/kconfig/menu.c
>> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
>> {
>> int i, j;
>> struct menu *submenu[8], *menu, *location = NULL;
>> - struct jump_key *jump;
>> + struct jump_key *jump = NULL;
>>
>> str_printf(r, _("Prompt: %s\n"), _(prop->text));
>> menu = prop->menu->parent;
>>
> Hello Zhen-Hua,
>
> the patch looks incomplete to me. A check
> jump != NULL
> should be added before accessing parts of structure jump_key.
>
> Best regards
>
> Heinrich Schuchardt
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
2014-07-14 16:30 ` Heinrich Schuchardt
@ 2014-07-15 8:53 ` Li, ZhenHua
0 siblings, 0 replies; 6+ messages in thread
From: Li, ZhenHua @ 2014-07-15 8:53 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Yann E. MORIN, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Heinrich,
Thank you very much for reviewing. But seems the maintainer will not
accept it.
Zhenhua
On 07/15/2014 12:30 AM, Heinrich Schuchardt wrote:
> On 01.07.2014 01:10, Li, Zhen-Hua wrote:
>> When malloc for jump,
>> if (head && location) {
>> jump = xmalloc(sizeof(struct jump_key));
>> ....
>> }
>> And here it is used:
>> if (head && location && menu == location)
>> jump->offset = strlen(r->s);
>>
>>
>> So I think when jump is used, it must not be NULL; then !=NULL is not
>> needed.
>
> I tested the patch against v13.6-rc5. It fixes the problem with the
> warning.
>
> You can add
>
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Best regards
>
> Heinrich
>
>
>> -----Original Message-----
>> From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de]
>> Sent: Tuesday, July 01, 2014 1:03 AM
>> To: Li, Zhen-Hua; Yann E. MORIN; linux-kbuild@vger.kernel.org;
>> linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
>>
>> On 30.06.2014 05:16, Li, Zhen-Hua wrote:
>>> There is a warning when run "make menuconfig".
>>>
>>> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
>>> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used
>>> uninitialized in
>>> this function [-Wmaybe-uninitialized]
>>> jump->offset = strlen(r->s);
>>> ^
>>> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
>>> struct jump_key *jump;
>>> ^
>>>
>>> It is because the compiler think "jump" is not initialized, though
>>> in fact
>>> it is already initialized.
>>>
>>> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
>>> ---
>>> scripts/kconfig/menu.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
>>> index a26cc5d..584e0fc 100644
>>> --- a/scripts/kconfig/menu.c
>>> +++ b/scripts/kconfig/menu.c
>>> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r,
>>> struct property *prop,
>>> {
>>> int i, j;
>>> struct menu *submenu[8], *menu, *location = NULL;
>>> - struct jump_key *jump;
>>> + struct jump_key *jump = NULL;
>>>
>>> str_printf(r, _("Prompt: %s\n"), _(prop->text));
>>> menu = prop->menu->parent;
>>>
>> Hello Zhen-Hua,
>>
>> the patch looks incomplete to me. A check
>> jump != NULL
>> should be added before accessing parts of structure jump_key.
>>
>> Best regards
>>
>> Heinrich Schuchardt
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig
2014-06-30 17:02 ` Heinrich Schuchardt
2014-06-30 23:10 ` Li, Zhen-Hua
@ 2014-07-14 6:25 ` Li, ZhenHua
1 sibling, 0 replies; 6+ messages in thread
From: Li, ZhenHua @ 2014-07-14 6:25 UTC (permalink / raw)
To: Heinrich Schuchardt, Yann E. MORIN; +Cc: linux-kbuild, linux-kernel
Any update?
On 07/01/2014 01:02 AM, Heinrich Schuchardt wrote:
> On 30.06.2014 05:16, Li, Zhen-Hua wrote:
>> There is a warning when run "make menuconfig".
>>
>> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
>> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used
>> uninitialized in
>> this function [-Wmaybe-uninitialized]
>> jump->offset = strlen(r->s);
>> ^
>> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
>> struct jump_key *jump;
>> ^
>>
>> It is because the compiler think "jump" is not initialized, though in
>> fact
>> it is already initialized.
>>
>> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
>> ---
>> scripts/kconfig/menu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
>> index a26cc5d..584e0fc 100644
>> --- a/scripts/kconfig/menu.c
>> +++ b/scripts/kconfig/menu.c
>> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct
>> property *prop,
>> {
>> int i, j;
>> struct menu *submenu[8], *menu, *location = NULL;
>> - struct jump_key *jump;
>> + struct jump_key *jump = NULL;
>>
>> str_printf(r, _("Prompt: %s\n"), _(prop->text));
>> menu = prop->menu->parent;
>>
> Hello Zhen-Hua,
>
> the patch looks incomplete to me. A check
> jump != NULL
> should be added before accessing parts of structure jump_key.
>
> Best regards
>
> Heinrich Schuchardt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-15 8:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30 3:16 [PATCH 1/1] script/kconfig: remove a warning for menucofig Li, Zhen-Hua
2014-06-30 17:02 ` Heinrich Schuchardt
2014-06-30 23:10 ` Li, Zhen-Hua
2014-07-14 16:30 ` Heinrich Schuchardt
2014-07-15 8:53 ` Li, ZhenHua
2014-07-14 6:25 ` Li, ZhenHua
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox