* [PATCH] kernel:async :changed printk to pr_debug to respect coding style.
@ 2014-07-14 9:29 Ionut Alexa
0 siblings, 0 replies; 3+ messages in thread
From: Ionut Alexa @ 2014-07-14 9:29 UTC (permalink / raw)
To: arjan, akpm; +Cc: linux-kernel, Ionut Alexa
Fixed coding style issues by replacing printk with pr_debug.
Signed-off-by: Ionut Alexa <ionut.m.alexa@gmail.com>
---
kernel/async.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/kernel/async.c b/kernel/async.c
index 61f023c..c82276c 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -111,11 +111,12 @@ static void async_run_entry_fn(struct work_struct *work)
struct async_entry *entry =
container_of(work, struct async_entry, work);
unsigned long flags;
+
ktime_t uninitialized_var(calltime), delta, rettime;
/* 1) run (and print duration) */
if (initcall_debug && system_state == SYSTEM_BOOTING) {
- printk(KERN_DEBUG "calling %lli_%pF @ %i\n",
+ pr_debug("calling %lli_%pF @ %i\n",
(long long)entry->cookie,
entry->func, task_pid_nr(current));
calltime = ktime_get();
@@ -124,7 +125,7 @@ static void async_run_entry_fn(struct work_struct *work)
if (initcall_debug && system_state == SYSTEM_BOOTING) {
rettime = ktime_get();
delta = ktime_sub(rettime, calltime);
- printk(KERN_DEBUG "initcall %lli_%pF returned 0 after %lld usecs\n",
+ pr_debug("initcall %lli_%pF returned 0 after %lld usecs\n",
(long long)entry->cookie,
entry->func,
(long long)ktime_to_ns(delta) >> 10);
@@ -285,7 +286,7 @@ void async_synchronize_cookie_domain(async_cookie_t cookie, struct async_domain
ktime_t uninitialized_var(starttime), delta, endtime;
if (initcall_debug && system_state == SYSTEM_BOOTING) {
- printk(KERN_DEBUG "async_waiting @ %i\n", task_pid_nr(current));
+ pr_debug("async_waiting @ %i\n", task_pid_nr(current));
starttime = ktime_get();
}
@@ -295,7 +296,7 @@ void async_synchronize_cookie_domain(async_cookie_t cookie, struct async_domain
endtime = ktime_get();
delta = ktime_sub(endtime, starttime);
- printk(KERN_DEBUG "async_continuing @ %i after %lli usec\n",
+ pr_debug("async_continuing @ %i after %lli usec\n",
task_pid_nr(current),
(long long)ktime_to_ns(delta) >> 10);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] kernel:async :changed printk to pr_debug to respect coding style.
@ 2014-07-14 9:45 Ionut Alexa
2014-07-14 13:14 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Ionut Alexa @ 2014-07-14 9:45 UTC (permalink / raw)
To: arjan, akpm; +Cc: linux-kernel, Ionut Alexa
Fixed coding style issues by replacing printk with pr_debug.
Signed-off-by: Ionut Alexa <ionut.m.alexa@gmail.com>
---
kernel/async.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/kernel/async.c b/kernel/async.c
index 61f023c..c82276c 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -111,11 +111,12 @@ static void async_run_entry_fn(struct work_struct *work)
struct async_entry *entry =
container_of(work, struct async_entry, work);
unsigned long flags;
+
ktime_t uninitialized_var(calltime), delta, rettime;
/* 1) run (and print duration) */
if (initcall_debug && system_state == SYSTEM_BOOTING) {
- printk(KERN_DEBUG "calling %lli_%pF @ %i\n",
+ pr_debug("calling %lli_%pF @ %i\n",
(long long)entry->cookie,
entry->func, task_pid_nr(current));
calltime = ktime_get();
@@ -124,7 +125,7 @@ static void async_run_entry_fn(struct work_struct *work)
if (initcall_debug && system_state == SYSTEM_BOOTING) {
rettime = ktime_get();
delta = ktime_sub(rettime, calltime);
- printk(KERN_DEBUG "initcall %lli_%pF returned 0 after %lld usecs\n",
+ pr_debug("initcall %lli_%pF returned 0 after %lld usecs\n",
(long long)entry->cookie,
entry->func,
(long long)ktime_to_ns(delta) >> 10);
@@ -285,7 +286,7 @@ void async_synchronize_cookie_domain(async_cookie_t cookie, struct async_domain
ktime_t uninitialized_var(starttime), delta, endtime;
if (initcall_debug && system_state == SYSTEM_BOOTING) {
- printk(KERN_DEBUG "async_waiting @ %i\n", task_pid_nr(current));
+ pr_debug("async_waiting @ %i\n", task_pid_nr(current));
starttime = ktime_get();
}
@@ -295,7 +296,7 @@ void async_synchronize_cookie_domain(async_cookie_t cookie, struct async_domain
endtime = ktime_get();
delta = ktime_sub(endtime, starttime);
- printk(KERN_DEBUG "async_continuing @ %i after %lli usec\n",
+ pr_debug("async_continuing @ %i after %lli usec\n",
task_pid_nr(current),
(long long)ktime_to_ns(delta) >> 10);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel:async :changed printk to pr_debug to respect coding style.
2014-07-14 9:45 [PATCH] kernel:async :changed printk to pr_debug to respect coding style Ionut Alexa
@ 2014-07-14 13:14 ` Arjan van de Ven
0 siblings, 0 replies; 3+ messages in thread
From: Arjan van de Ven @ 2014-07-14 13:14 UTC (permalink / raw)
To: Ionut Alexa, akpm; +Cc: linux-kernel
On 7/14/2014 2:45 AM, Ionut Alexa wrote:
> Fixed coding style issues by replacing printk with pr_debug.
these actual user prints are used by certain tools, like scripts/bootgraph.pl
you forgot to adapt these tools to the printk format change that you are doing....
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-14 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-14 9:45 [PATCH] kernel:async :changed printk to pr_debug to respect coding style Ionut Alexa
2014-07-14 13:14 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2014-07-14 9:29 Ionut Alexa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox