From: Jongsung Kim <neidhard.kim@lge.com>
To: Varka Bhadram <varkabhadram@gmail.com>, nicolas.ferre@atmel.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH 1/2] net: cadence: macb: add support for the WOL
Date: Tue, 15 Jul 2014 16:02:34 +0900 [thread overview]
Message-ID: <53C4D20A.2050909@lge.com> (raw)
In-Reply-To: <53C3ADB9.4010309@gmail.com>
On 07/14/2014 07:15 PM, Varka Bhadram wrote:
>
> I think we can do in this way:
>
> if (phydev)
> return phy_ethtool_set_wol(phydev, wol);
> else
> return -ENODEV;
>
>
> we can save err. What do you say ...?
>
Thank you for your comment. I just wanted the function to return
at one position. However, I'll think about your point..
prev parent reply other threads:[~2014-07-15 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 9:02 [PATCH 1/2] net: cadence: macb: add support for the WOL Jongsung Kim
2014-07-14 10:15 ` Varka Bhadram
2014-07-14 10:49 ` David Laight
2014-07-14 10:53 ` Varka Bhadram
2014-07-15 6:58 ` Jongsung Kim
2014-07-15 7:02 ` Jongsung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4D20A.2050909@lge.com \
--to=neidhard.kim@lge.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox