From: Clemens Ladisch <clemens@ladisch.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Borislav Petkov <bp@alien8.de>,
jdelvare@suse.de, rdunlap@infradead.org, bhelgaas@google.com,
lm-sensors@lm-sensors.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] hwmon, k10temp: Add support for AMD F15h M60h processor
Date: Tue, 15 Jul 2014 09:41:33 +0200 [thread overview]
Message-ID: <53C4DB2D.80406@ladisch.de> (raw)
In-Reply-To: <20140714203336.GA30926@roeck-us.net>
Guenter Roeck wrote:
> On Mon, Jul 14, 2014 at 10:21:51PM +0200, Clemens Ladisch wrote:
>> Borislav Petkov wrote:
>>> On Mon, Jul 14, 2014 at 03:23:08PM -0500, Aravind Gopalakrishnan wrote:
>>>> + if (boot_cpu_data.x86 == 0x15 && boot_cpu_data.x86_model == 0x60) {
>>>> + pci_bus_write_config_dword(pdev->bus, PCI_DEVFN(0, 0),
>>>> + NB_SMU_IND_ADDR, IND_ADDR_OFFSET);
>>>> + pci_bus_read_config_dword(pdev->bus, PCI_DEVFN(0, 0),
>>>> + NB_SMU_IND_DATA, ®val);
>>
>> How do you prevent races with any other code that accesses some indirect
>> register?
>>
> I just wanted to ask exactly the same question. I think this will need
> locking.
If there actually is any other code; these indirect SMU registers appear
to be mostly undocumented and to be intended to be used by the BIOS.
(Which makes me wonder why the temperature sensor was moved there.)
Anyway, if a lock is needed, it looks as if it could go into a helper
function such as "amd_nb_smu_ind_read()" in arch/x86/kernel/amd_nb.c.
Regards,
Clemens
next prev parent reply other threads:[~2014-07-15 7:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 20:23 [PATCH] hwmon, k10temp: Add support for AMD F15h M60h processor Aravind Gopalakrishnan
2014-07-14 19:51 ` Borislav Petkov
2014-07-14 19:59 ` Aravind Gopalakrishnan
2014-07-14 20:06 ` Guenter Roeck
2014-07-14 20:21 ` Clemens Ladisch
2014-07-14 20:33 ` Guenter Roeck
2014-07-15 7:41 ` Clemens Ladisch [this message]
2014-07-15 9:03 ` Guenter Roeck
2014-07-17 15:22 ` Aravind Gopalakrishnan
2014-07-17 16:02 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4DB2D.80406@ladisch.de \
--to=clemens@ladisch.de \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jdelvare@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox