public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH for 3.16] IB/mlx5: Enable block multicast loopback for kernel consumers too
       [not found] <1403703854-14328-1-git-send-email-ogerlitz@mellanox.com>
@ 2014-07-15  8:42 ` Or Gerlitz
  0 siblings, 0 replies; only message in thread
From: Or Gerlitz @ 2014-07-15  8:42 UTC (permalink / raw)
  To: roland; +Cc: linux-rdma, haggaie, Eli Cohen, linux-kernel, Roland Dreier

On 25/06/2014 16:44, Or Gerlitz wrote:
> Under commit f360d88 we advertize blocking multicast loopback to both
> kernel and user-space consumers, but disallow the kernel ones (e.g IPoIB)
> to use it with their UD QPs, fix that.
>
> Fixes: f360d88 ('IB/mlx5: Add block multicast loopback support')
> Reported-by: Haggai Eran <haggaie@mellanox.com>
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
> ---

Roland, this needs to go into 3.16 and 3.15-stable too as the bug was 
introduced in 3.15-rc2, please make sure to add it to your 3.16 rc pull 
request, OK?

Or.

>   drivers/infiniband/hw/mlx5/qp.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
> index d13ddf1..bbbcf38 100644
> --- a/drivers/infiniband/hw/mlx5/qp.c
> +++ b/drivers/infiniband/hw/mlx5/qp.c
> @@ -675,7 +675,7 @@ static int create_kernel_qp(struct mlx5_ib_dev *dev,
>   	int err;
>
>   	uuari = &dev->mdev.priv.uuari;
> -	if (init_attr->create_flags & ~IB_QP_CREATE_SIGNATURE_EN)
> +	if (init_attr->create_flags & ~(IB_QP_CREATE_SIGNATURE_EN | IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK))
>   		return -EINVAL;
>
>   	if (init_attr->qp_type == MLX5_IB_QPT_REG_UMR)
>


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-07-15  8:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1403703854-14328-1-git-send-email-ogerlitz@mellanox.com>
2014-07-15  8:42 ` [PATCH for 3.16] IB/mlx5: Enable block multicast loopback for kernel consumers too Or Gerlitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox