[PATCH] scripts: sortextable: change type and initialise variable

[PATCH] scripts: sortextable: change type and initialise variable

[Klemen Jan Enova]

Change the type of 'relocs_size' from 'int' to 'Elf32_Word' and 
initialize it to 0, to fix the "maybe uninitialised variable" compiler 
warning.

Signed-off-by: Klemen Jan Enova <klemen.jan.enova@gmail.com>
---
diff --git a/scripts/sortextable.h b/scripts/sortextable.h
index 8fac3fd..537858d 100644
--- a/scripts/sortextable.h
+++ b/scripts/sortextable.h
@@ -103,7 +103,7 @@ do_func(Elf_Ehdr *ehdr, char const *const fname, 
table_sort_
         Elf_Sym *sort_needed_sym;
         Elf_Shdr *sort_needed_sec;
         Elf_Rel *relocs = NULL;
-       int relocs_size;
+       Elf32_Word relocs_size = 0;
         uint32_t *sort_done_location;
         const char *secstrtab;
         const char *strtab;

Re: [PATCH] scripts: sortextable: change type and initialise variable

[Michal Marek]

On 2014-07-15 11:12, Klemen Jan Enova wrote:
> Change the type of 'relocs_size' from 'int' to 'Elf32_Word' and 
> initialize it to 0, to fix the "maybe uninitialised variable" compiler 
> warning.

Please include the verbatim warning in the commit message.



> Signed-off-by: Klemen Jan Enova <klemen.jan.enova@gmail.com>
> ---
> diff --git a/scripts/sortextable.h b/scripts/sortextable.h
> index 8fac3fd..537858d 100644
> --- a/scripts/sortextable.h
> +++ b/scripts/sortextable.h
> @@ -103,7 +103,7 @@ do_func(Elf_Ehdr *ehdr, char const *const fname, 
> table_sort_

Your mailer corrupted the patch by inserting a line break here.


>          Elf_Sym *sort_needed_sym;
>          Elf_Shdr *sort_needed_sec;
>          Elf_Rel *relocs = NULL;
> -       int relocs_size;
> +       Elf32_Word relocs_size = 0;

... and changed tabs to spaces. Please send the patch to yourself first
and see if it applies with 'git am.'

Michal