* [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func
@ 2014-07-15 3:13 sam-the-6
2014-07-15 7:07 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: sam-the-6 @ 2014-07-15 3:13 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, Sam Asadi
From: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
modified: drivers/staging/comedi/drivers/8253.h
---
drivers/staging/comedi/drivers/8253.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8253.h b/drivers/staging/comedi/drivers/8253.h
index 5829b46..f6b8607 100644
--- a/drivers/staging/comedi/drivers/8253.h
+++ b/drivers/staging/comedi/drivers/8253.h
@@ -55,7 +55,7 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
/* check for overflow */
divider > div1 && divider > div2 &&
divider * i8253_osc_base > divider &&
- divider * i8253_osc_base > i8253_osc_base) {
+ divider * i8253_osc_base > i8253_osc_base) {
return;
}
@@ -118,7 +118,6 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
/* masking is done since counter maps zero to 0x10000 */
*d1 = div1 & 0xffff;
*d2 = div2 & 0xffff;
- return;
}
#ifndef CMDTEST
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func
2014-07-15 3:13 [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func sam-the-6
@ 2014-07-15 7:07 ` Dan Carpenter
2014-07-15 10:16 ` Ian Abbott
2014-07-15 13:54 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2014-07-15 7:07 UTC (permalink / raw)
To: sam-the-6; +Cc: abbotti, hsweeten, gregkh, devel, linux-kernel
Oh, wow. No. All these patches are wrong but there are too many to
discuss them individually.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func
2014-07-15 3:13 [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func sam-the-6
2014-07-15 7:07 ` Dan Carpenter
@ 2014-07-15 10:16 ` Ian Abbott
2014-07-15 13:54 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2014-07-15 10:16 UTC (permalink / raw)
To: sam-the-6, hsweeten, gregkh; +Cc: devel, linux-kernel
On 2014-07-15 04:13, sam-the-6 wrote:
> From: Sam Asadi <asadi.samuel@gmail.com>
>
> Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
>
> modified: drivers/staging/comedi/drivers/8253.h
> ---
> drivers/staging/comedi/drivers/8253.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/8253.h b/drivers/staging/comedi/drivers/8253.h
> index 5829b46..f6b8607 100644
> --- a/drivers/staging/comedi/drivers/8253.h
> +++ b/drivers/staging/comedi/drivers/8253.h
> @@ -55,7 +55,7 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
> /* check for overflow */
> divider > div1 && divider > div2 &&
> divider * i8253_osc_base > divider &&
> - divider * i8253_osc_base > i8253_osc_base) {
> + divider * i8253_osc_base > i8253_osc_base) {
Keep the space before the '{'. Don't replace it with a tab.
> return;
> }
>
> @@ -118,7 +118,6 @@ static inline void i8253_cascade_ns_to_timer(int i8253_osc_base,
> /* masking is done since counter maps zero to 0x10000 */
> *d1 = div1 & 0xffff;
> *d2 = div2 & 0xffff;
> - return;
> }
>
> #ifndef CMDTEST
>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func
2014-07-15 3:13 [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func sam-the-6
2014-07-15 7:07 ` Dan Carpenter
2014-07-15 10:16 ` Ian Abbott
@ 2014-07-15 13:54 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2014-07-15 13:54 UTC (permalink / raw)
To: sam-the-6; +Cc: abbotti, hsweeten, devel, linux-kernel
On Tue, Jul 15, 2014 at 06:13:19AM +0300, sam-the-6 wrote:
> From: Sam Asadi <asadi.samuel@gmail.com>
>
> Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Where are the other 90 patches in this series, I only received 91, 92,
93, and 94. Wait, 94 out of 93???? What is going on here?
>
> modified: drivers/staging/comedi/drivers/8253.h
What is this line for?
Also, please look at your email client's "From:" line up above, it isn't
matching your From: and Signed-off-by: line in the body of the patch,
why?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-15 13:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-15 3:13 [PATCH 91/93] Staging: comedi: 8253.h fixed by removing 'return' from generic func sam-the-6
2014-07-15 7:07 ` Dan Carpenter
2014-07-15 10:16 ` Ian Abbott
2014-07-15 13:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox