* [PATCH] perf: Fix missing vdso name in mmap events for x86
@ 2014-07-15 10:24 Adrian Hunter
2014-07-15 11:08 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2014-07-15 10:24 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, Andy Lutomirski,
H. Peter Anvin, Jiri Olsa, Namhyung Kim, Paul Mackerras
Commit 78d683e838a60ec4ba4591cca4364cba84a9e626
added vm_ops->name as an alternative to arch_vma_name
but did not update perf events use of arch_vma_name().
Commit a62c34bd2a8a3f159945becd57401e478818d51c
removed "[vdso]" as a name returned by the x86 version of
arch_vma_name(), so the perf event for the vdso mapping
no longer had the correct name.
Fix by making perf events also use vm_ops->name.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
kernel/events/core.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index a33d9a2b..a8740d1 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -5266,6 +5266,12 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)
goto got_name;
} else {
+ if (vma->vm_ops && vma->vm_ops->name) {
+ name = (char *)vma->vm_ops->name(vma);
+ if (name)
+ goto cpy_name;
+ }
+
name = (char *)arch_vma_name(vma);
if (name)
goto cpy_name;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf: Fix missing vdso name in mmap events for x86
2014-07-15 10:24 [PATCH] perf: Fix missing vdso name in mmap events for x86 Adrian Hunter
@ 2014-07-15 11:08 ` Peter Zijlstra
2014-07-15 11:17 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2014-07-15 11:08 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, linux-kernel,
Andy Lutomirski, H. Peter Anvin, Jiri Olsa, Namhyung Kim,
Paul Mackerras
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Tue, Jul 15, 2014 at 01:24:04PM +0300, Adrian Hunter wrote:
> Commit 78d683e838a60ec4ba4591cca4364cba84a9e626
> added vm_ops->name as an alternative to arch_vma_name
> but did not update perf events use of arch_vma_name().
>
> Commit a62c34bd2a8a3f159945becd57401e478818d51c
> removed "[vdso]" as a name returned by the x86 version of
> arch_vma_name(), so the perf event for the vdso mapping
> no longer had the correct name.
>
> Fix by making perf events also use vm_ops->name.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
I've already got:
http://lkml.kernel.org/r/1405353439-14211-1-git-send-email-jolsa@kernel.org
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: Fix missing vdso name in mmap events for x86
2014-07-15 11:08 ` Peter Zijlstra
@ 2014-07-15 11:17 ` Adrian Hunter
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2014-07-15 11:17 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Ingo Molnar, Arnaldo Carvalho de Melo, linux-kernel,
Andy Lutomirski, H. Peter Anvin, Jiri Olsa, Namhyung Kim,
Paul Mackerras
On 07/15/2014 02:08 PM, Peter Zijlstra wrote:
> On Tue, Jul 15, 2014 at 01:24:04PM +0300, Adrian Hunter wrote:
>> Commit 78d683e838a60ec4ba4591cca4364cba84a9e626
>> added vm_ops->name as an alternative to arch_vma_name
>> but did not update perf events use of arch_vma_name().
>>
>> Commit a62c34bd2a8a3f159945becd57401e478818d51c
>> removed "[vdso]" as a name returned by the x86 version of
>> arch_vma_name(), so the perf event for the vdso mapping
>> no longer had the correct name.
>>
>> Fix by making perf events also use vm_ops->name.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> I've already got:
> http://lkml.kernel.org/r/1405353439-14211-1-git-send-email-jolsa@kernel.org
>
Sorry, didn't see that.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-15 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-15 10:24 [PATCH] perf: Fix missing vdso name in mmap events for x86 Adrian Hunter
2014-07-15 11:08 ` Peter Zijlstra
2014-07-15 11:17 ` Adrian Hunter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox