From: Andrey Ryabinin <a.ryabinin@samsung.com>
To: Christoph Lameter <cl@gentwo.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Dmitry Vyukov <dvyukov@google.com>,
Konstantin Serebryany <kcc@google.com>,
Alexey Preobrazhensky <preobr@google.com>,
Andrey Konovalov <adech.fo@gmail.com>,
Yuri Gribov <tetra2005@gmail.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>,
Michal Marek <mmarek@suse.cz>,
Russell King <linux@arm.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kbuild@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
linux-mm@kvack.org
Subject: Re: [RFC/PATCH -next 00/21] Address sanitizer for kernel (kasan) - dynamic memory error detector.
Date: Tue, 15 Jul 2014 18:32:23 +0400 [thread overview]
Message-ID: <53C53B77.3080000@samsung.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1407141012520.25405@gentwo.org>
On 07/14/14 19:13, Christoph Lameter wrote:
> On Sun, 13 Jul 2014, Andrey Ryabinin wrote:
>
>>> How does that work when memory is sparsely populated?
>>>
>>
>> Sparsemem configurations currently may not work with kasan.
>> I suppose I will have to move shadow area to vmalloc address space and
>> make it (shadow) sparse too if needed.
>
> Well it seems to work with sparsemem / vmemmap? So non vmmemmapped configs
> of sparsemem only. vmemmmap can also handle holes in memory.
>
>
Not sure. This sparsemem/vmemmap thing is kinda new to me, so I need to dig some more
to understand how it iтteracts with kasan.
As far as I understand the main problem with sparsemem & kasan is shadow allocation:
unsigned long lowmem_size = (unsigned long)high_memory - PAGE_OFFSET;
shadow_size = lowmem_size >> KASAN_SHADOW_SCALE_SHIFT;
shadow_phys_start = memblock_alloc(shadow_size, PAGE_SIZE);
If we don't have one big enough physically contiguous block for shadow it will fail.
prev parent reply other threads:[~2014-07-15 14:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 11:00 [RFC/PATCH -next 00/21] Address sanitizer for kernel (kasan) - dynamic memory error detector Andrey Ryabinin
2014-07-09 11:00 ` [RFC/PATCH -next 01/21] Add kernel address sanitizer infrastructure Andrey Ryabinin
2014-07-09 11:00 ` [RFC/PATCH -next 02/21] init: main: initialize kasan's shadow area on boot Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 03/21] x86: add kasan hooks fort memcpy/memmove/memset functions Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 04/21] x86: boot: vdso: disable instrumentation for code not linked with kernel Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 05/21] x86: cpu: don't sanitize early stages of a secondary CPU boot Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 06/21] x86: mm: init: allocate shadow memory for kasan Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 07/21] x86: Kconfig: enable kernel address sanitizer Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 08/21] mm: page_alloc: add kasan hooks on alloc and free pathes Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 09/21] mm: Makefile: kasan: don't instrument slub.c and slab_common.c files Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 10/21] mm: slab: share virt_to_cache() between slab and slub Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 11/21] mm: slub: share slab_err and object_err functions Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 12/21] mm: util: move krealloc/kzfree to slab_common.c Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 13/21] mm: slub: add allocation size field to struct kmem_cache Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 14/21] mm: slub: kasan: disable kasan when touching unaccessible memory Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 15/21] mm: slub: add kernel address sanitizer hooks to slub allocator Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 16/21] arm: boot: compressed: disable kasan's instrumentation Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 17/21] arm: add kasan hooks fort memcpy/memmove/memset functions Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 18/21] arm: mm: reserve shadow memory for kasan Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 19/21] arm: Kconfig: enable kernel address sanitizer Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 20/21] fs: dcache: manually unpoison dname after allocation to shut up kasan's reports Andrey Ryabinin
2014-07-09 11:01 ` [RFC/PATCH -next 21/21] lib: add kmalloc_bug_test module Andrey Ryabinin
2014-07-12 0:59 ` [RFC/PATCH -next 00/21] Address sanitizer for kernel (kasan) - dynamic memory error detector H. Peter Anvin
2014-07-13 10:39 ` Andrey Ryabinin
2014-07-14 15:13 ` Christoph Lameter
2014-07-15 14:32 ` Andrey Ryabinin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C53B77.3080000@samsung.com \
--to=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kcc@google.com \
--cc=koct9i@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=penberg@kernel.org \
--cc=preobr@google.com \
--cc=rientjes@google.com \
--cc=ryabinin.a.a@gmail.com \
--cc=sasha.levin@oracle.com \
--cc=tetra2005@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox