From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933182AbaGOW5t (ORCPT ); Tue, 15 Jul 2014 18:57:49 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:33101 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbaGOW5r (ORCPT ); Tue, 15 Jul 2014 18:57:47 -0400 Message-ID: <53C5B1F7.3000409@gmail.com> Date: Tue, 15 Jul 2014 18:57:59 -0400 From: Pranith Kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: josh@joshtriplett.org CC: "Paul E. McKenney" , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , "open list:READ-COPY UPDATE..." Subject: Re: [PATCH 2/3] rcu: Remove stale comment in tree.c References: <1405463509-2468-1-git-send-email-bobby.prani@gmail.com> <1405463509-2468-2-git-send-email-bobby.prani@gmail.com> <20140715225313.GB24290@cloud> In-Reply-To: <20140715225313.GB24290@cloud> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2014 06:53 PM, josh@joshtriplett.org wrote: > On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote: >> This commit removes a stale comment in rcu/tree.c. >> FYI, an updated comment exists a few lines below this. >> >> Signed-off-by: Pranith Kumar > In general, when removing a stale comment, I'd suggest explaining why > the comment is stale. Was code removed without removing the > corresponding comment, or was code changed such that the comment no > longer applies, or...? I guess it was left out when code was moved around previously. And I did mention that an updated comment is there a few lines below. For reference this is the new comment which is below the old comment, they mean the same :) /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */