Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

Mark Brown
2014-07-16T14:19:10Z

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

On Wed, Jul 16, 2014 at 05:00:54PM +0300, Ivan T. Ivanov wrote:
> On Wed, 2014-07-16 at 14:53 +0100, Mark Brown wrote:

> > No, this isn't an either/or thing - the dependency is absolutely
> > mandatory if the device needs SPMI. The defconfigs are a separate
> > thing, they just exist to give people a starting point for configuring
> > their kernel so if the device using SPMI is important for relevant
> > systems the defconfig needs to be set up to enable it but that's
> > separate to the dependency since there's no need for people to ever even
> > look at defconfigs.

> Then config REGMAP_SPMI should depend on SPMI, right?

No, REGMAP_SPMI is not something that can be enabled directly - it is
selected by its users which should be ensuring that SPMI is enabled as
it is difficult to see a use case for REGMAP_SPMI which does not do
this.

A dependency from a selected symbol will have no effect.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]