Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

Pramod Gurav
2014-07-16T12:56:18Z

Hi,

On Wednesday, 16 July, 2014 5:55pm, "Stanimir Varbanov" <svarbanov@mm-sol.com> said:

> <snip>
>
>>>>
>>>> config REGMAP_SPMI
>>>> + select SPMI
>>>
>>> NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and
>>> multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example.
>>>
>>
>> I am using multi_v7_defconfig but its not enabling it. I ran qcom_defconfig which
>> does.
>
> yes, it seems reasonable to add it in multi_v7_defconfig also.
>

Thanks.
I misunderstood the Kconfig documentation which says, "Reverse dependencies can only be used with boolean or tristate symbols". In the note following this statement doc says, "In general use select only for non-visible symbols".

The CONFIG_SPMI option is visible in menuconfig hence either it should be set by default in multi_v7_defconfig(like in qcom_defconfig) or driver owner should mention a 'depneds on CONFIG_SPMI' as suggested by Lars-Peter Clausen.
I prefer the former (defconfig).

Shall I send a new patch adding it in multi_v7_defconfig?

>
> --
> regards,
> Stan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>