Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

Stanimir Varbanov
2014-07-16T12:07:14Z

Hi,

<snip>
>
> Signed-off-by: Pramod Gurav <pramod.gurav.etc@gmail.com>
> CC: Josh Cartwright <joshc@codeaurora.org>
> CC: Mark Brown <broonie@linaro.org>
> ---
> This was found when I enabled support for Qualcomm QPNP PMICs and was
> compiling it. It selects REGMAP_SPMI and hence the crash.
>
> drivers/base/regmap/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 4251570..1aa9d71 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -16,6 +16,7 @@ config REGMAP_SPI
> tristate
>
> config REGMAP_SPMI
> + select SPMI

NO, IMO the CONFIG_SPMI should be enabled by qcom_defconfig and
multi_v7_defconfig. See CONFIG_I2C and REGMAP_I2C for example.

--
regards,
Stan