Re: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected

Mark Brown
2014-07-16T13:54:05Z

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Wed, Jul 16, 2014 at 06:26:15PM +0530, Pramod Gurav wrote:

Fix your mailer to word wrap within paragraphs, this will make your
mails more legible - see Documentation/email-clients.txt.

> On Wednesday, 16 July, 2014 5:55pm, "Stanimir Varbanov" <svarbanov@mm-sol.com> said:

> The CONFIG_SPMI option is visible in menuconfig hence either it should
> be set by default in multi_v7_defconfig(like in qcom_defconfig) or
> driver owner should mention a 'depneds on CONFIG_SPMI' as suggested by
> Lars-Peter Clausen.

> I prefer the former (defconfig).

No, this isn't an either/or thing - the dependency is absolutely
mandatory if the device needs SPMI. The defconfigs are a separate
thing, they just exist to give people a starting point for configuring
their kernel so if the device using SPMI is important for relevant
systems the defconfig needs to be set up to enable it but that's
separate to the dependency since there's no need for people to ever even
look at defconfigs.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]