From: Tomasz Figa <t.figa@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c
Date: Thu, 17 Jul 2014 15:15:52 +0200 [thread overview]
Message-ID: <53C7CC88.5040707@samsung.com> (raw)
In-Reply-To: <1405520417-15027-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 16.07.2014 16:20, Krzysztof Kozlowski wrote:
> Cleanup a little the SMP/hotplug code for Exynos by:
> 1. Moving completely all functions from hotplug.c into the platsmp.c;
> 2. Deleting the hotplug.c file.
>
> After recent cleanups (e.g. 75ad2ab28f0f "ARM: EXYNOS: use
> v7_exit_coherency_flush macro for cache disabling") there was only CPU
> power down related code in hotplug.c file. Keeping this file does not
> give any benefits.
>
> The commit only moves code around with one additional observable change:
> the hotplug.c was compiled with custom CFLAGS (-march=armv7-a). These
> CFLAGS are not necessary any more.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/mach-exynos/Makefile | 3 --
> arch/arm/mach-exynos/common.h | 2 -
> arch/arm/mach-exynos/hotplug.c | 92 ------------------------------------------
> arch/arm/mach-exynos/platsmp.c | 74 +++++++++++++++++++++++++++++++++
> 4 files changed, 74 insertions(+), 97 deletions(-)
> delete mode 100644 arch/arm/mach-exynos/hotplug.c
>
For this and remaining patches from this series:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
prev parent reply other threads:[~2014-07-17 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 14:20 [PATCH 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c Krzysztof Kozlowski
2014-07-16 14:20 ` [PATCH 2/3] ARM: EXYNOS: Remove unneeded __ref annotation for cpu_die function Krzysztof Kozlowski
2014-07-16 14:20 ` [PATCH 3/3] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off Krzysztof Kozlowski
2014-07-17 13:15 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C7CC88.5040707@samsung.com \
--to=t.figa@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox