From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <linux-mips@linux-mips.org>,
<dborkman@redhat.com>, <ralf@linux-mips.org>
Subject: Re: [PATCH 2/3] arch/mips/net/bpf_jit.c: fix failure check
Date: Thu, 17 Jul 2014 15:12:26 +0100 [thread overview]
Message-ID: <53C7D9CA.20405@imgtec.com> (raw)
In-Reply-To: <CANZNk81DOOxYYFSKZMCh=uABd3ONB8wToTFc3_L_9TfyQDS1yQ@mail.gmail.com>
On 07/17/2014 02:58 PM, Andrey Utkin wrote:
> 2014-07-17 16:52 GMT+03:00 Markos Chandras <Markos.Chandras@imgtec.com>:
>> Thanks for the patch. I would personally prefer to use a new signed int
>> variable, but I am fine either way.
>
> If that's not a problem for performance etc., then i'll resubmit with
> new temporary signed variable, because i believe it would be simpler
> to comprehend.
>
Hi Andrey,
Well, this function is executed during the filter compilation so it's
only executed once (or maybe a few times) per filter (assuming the
filter uses the SKF_AD_PKTTYPE opcode at all) so performance is not
really critical at this point. The performance become a critical factor
for the execution of the jitted filter. But yes, avoiding passing the
argument and doing the pointer operation later on could save some
instructions which is both good for compilation performance and also
makes the function simpler as you said.
--
markos
next prev parent reply other threads:[~2014-07-17 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 13:27 [PATCH 2/3] arch/mips/net/bpf_jit.c: fix failure check Andrey Utkin
2014-07-17 13:52 ` Markos Chandras
2014-07-17 13:58 ` Andrey Utkin
2014-07-17 14:12 ` Markos Chandras [this message]
2014-07-17 14:22 ` [PATCH] " Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C7D9CA.20405@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=andrey.krieger.utkin@gmail.com \
--cc=dborkman@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox