From: Alex Elder <elder@linaro.org>
To: "Petr Mládek" <pmladek@suse.cz>
Cc: akpm@linux-foundation.org, bp@suse.de, john.stultz@linaro.org,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] printk: initialize syslog_prev and console_prev
Date: Fri, 18 Jul 2014 08:38:24 -0500 [thread overview]
Message-ID: <53C92350.40204@linaro.org> (raw)
In-Reply-To: <20140718104338.GX6774@pathway.suse.cz>
On 07/18/2014 05:43 AM, Petr Mládek wrote:
> On Thu 2014-07-17 09:09:06, Alex Elder wrote:
>> Two global variables, "syslog_prev" and "console_prev", maintain a
>> copy of the flags value used in the log record most recently
>> formatted for syslog or the console, respectively.
. . .
>> @@ -2148,7 +2148,7 @@ again:
>> /* messages are gone, move to first one */
>> console_seq = log_first_seq;
>> console_idx = log_first_idx;
>> - console_prev = 0;
>> + console_prev = LOG_NEWLINE;
>> } else {
>> len = 0;
>> }
>
> It would make sense to add '\n' if we skip something and the previous
> copied line was continuous. This would change the behavior, so we
> should do this in separate patch.
I'm working up a v3 of this series and have inserted a patch
that implements this at the beginning.
> Anyway, it makes sense to reset the flag to LOG_NEWLINE.
>
> Reviewed-by: Petr Mladek <pmladek@suse.cz>
Thanks a lot.
-Alex
next prev parent reply other threads:[~2014-07-18 13:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 14:09 [PATCH v2 0/6] printk: start simplifying some flags Alex Elder
2014-07-17 14:09 ` [PATCH v2 1/6] printk: initialize syslog_prev and console_prev Alex Elder
2014-07-18 10:43 ` Petr Mládek
2014-07-18 13:38 ` Alex Elder [this message]
2014-07-17 14:09 ` [PATCH v2 2/6] printk: LOG_CONT and LOG_NEWLINE are opposites Alex Elder
2014-07-18 10:53 ` Petr Mládek
2014-07-18 13:39 ` Alex Elder
2014-07-17 14:09 ` [PATCH v2 3/6] printk: honor LOG_PREFIX in devkmsg_read() Alex Elder
2014-07-17 14:09 ` [PATCH v2 4/6] printk: honor LOG_PREFIX in msg_print_text() Alex Elder
2014-07-18 11:03 ` Petr Mládek
2014-07-17 14:09 ` [PATCH v2 5/6] printk: insert newline in devkmsg_read() Alex Elder
2014-07-18 11:45 ` Petr Mládek
2014-07-18 14:02 ` Alex Elder
2014-07-17 14:09 ` [PATCH v2 6/6] printk: correct some more typos Alex Elder
2014-07-18 11:46 ` Petr Mládek
2014-07-17 15:59 ` [PATCH v2 0/6] printk: start simplifying some flags Joe Perches
2014-07-17 16:04 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C92350.40204@linaro.org \
--to=elder@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=jack@suse.cz \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox