From: Alex Elder <elder@linaro.org>
To: "Petr Mládek" <pmladek@suse.cz>
Cc: akpm@linux-foundation.org, bp@suse.de, john.stultz@linaro.org,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] printk: LOG_CONT and LOG_NEWLINE are opposites
Date: Fri, 18 Jul 2014 08:39:34 -0500 [thread overview]
Message-ID: <53C92396.2080007@linaro.org> (raw)
In-Reply-To: <20140718105356.GY6774@pathway.suse.cz>
On 07/18/2014 05:53 AM, Petr Mládek wrote:
>> @@ -1686,9 +1690,8 @@ asmlinkage int vprintk_emit(int facility, int level,
>> > if (cont_add(facility, level, text, text_len))
>> > printed_len += text_len;
>> > else
>> > - printed_len += log_store(facility, level,
>> > - lflags | LOG_CONT, 0,
>> > - dict, dictlen, text, text_len);
>> > + printed_len += log_store(facility, level, lflags, 0,
>> > + NULL, 0, text, text_len);
>> > } else {
>> > bool stored = false;
>> >
> I do not see real benefit in this change. I think that it would cause
> more confusion than help. I would suggest to remove it. Then I will
> agree with this patch :-)
Done. I'm going to add your Reviewed-by based on this. Please correct
me if that's not what you want.
-Alex
next prev parent reply other threads:[~2014-07-18 13:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 14:09 [PATCH v2 0/6] printk: start simplifying some flags Alex Elder
2014-07-17 14:09 ` [PATCH v2 1/6] printk: initialize syslog_prev and console_prev Alex Elder
2014-07-18 10:43 ` Petr Mládek
2014-07-18 13:38 ` Alex Elder
2014-07-17 14:09 ` [PATCH v2 2/6] printk: LOG_CONT and LOG_NEWLINE are opposites Alex Elder
2014-07-18 10:53 ` Petr Mládek
2014-07-18 13:39 ` Alex Elder [this message]
2014-07-17 14:09 ` [PATCH v2 3/6] printk: honor LOG_PREFIX in devkmsg_read() Alex Elder
2014-07-17 14:09 ` [PATCH v2 4/6] printk: honor LOG_PREFIX in msg_print_text() Alex Elder
2014-07-18 11:03 ` Petr Mládek
2014-07-17 14:09 ` [PATCH v2 5/6] printk: insert newline in devkmsg_read() Alex Elder
2014-07-18 11:45 ` Petr Mládek
2014-07-18 14:02 ` Alex Elder
2014-07-17 14:09 ` [PATCH v2 6/6] printk: correct some more typos Alex Elder
2014-07-18 11:46 ` Petr Mládek
2014-07-17 15:59 ` [PATCH v2 0/6] printk: start simplifying some flags Joe Perches
2014-07-17 16:04 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C92396.2080007@linaro.org \
--to=elder@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=jack@suse.cz \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox