From: Lars-Peter Clausen <lars@metafoo.de>
To: Richard Weinberger <richard@nod.at>, akpm@linux-foundation.org
Cc: apw@canonical.com, joe@perches.com, tytso@mit.edu,
dwalter@google.com, bp@suse.de, neilb@suse.de, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option
Date: Fri, 18 Jul 2014 16:17:42 +0200 [thread overview]
Message-ID: <53C92C86.2030408@metafoo.de> (raw)
In-Reply-To: <1405611268-12463-1-git-send-email-richard@nod.at>
On 07/17/2014 05:34 PM, Richard Weinberger wrote:
[...]
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.
I don't think this is a good solution the problem and I'm not sure how
successful it will actually be at fixing the problem. How about instead
properly documenting that single line trivial style cleanup patches are not
really helpful and people should not send them? (Maybe add a check to
checkpatch.pl that emits a warning if the patch is a trivial style cleanup ;))
--file is a in my opinion useful option and at least I use it on a regular
basis.
- Lars
next prev parent reply other threads:[~2014-07-18 14:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 15:34 [PATCH] checkpatch.pl: Remove --file option Richard Weinberger
2014-07-17 15:38 ` Borislav Petkov
2014-07-17 15:51 ` Joe Perches
2014-07-17 16:02 ` Borislav Petkov
2014-07-17 16:24 ` Joe Perches
2014-07-22 5:27 ` Kalle Valo
2014-08-04 14:30 ` Pavel Machek
2014-07-17 22:43 ` Thomas Gleixner
2014-07-18 7:29 ` Guenter Roeck
2014-07-18 8:23 ` Borislav Petkov
2014-07-18 13:37 ` Guenter Roeck
2014-07-18 13:46 ` Richard Weinberger
2014-07-18 13:56 ` Guenter Roeck
2014-07-18 14:22 ` Borislav Petkov
2014-07-18 14:21 ` Christoph Hellwig
2014-07-18 14:27 ` Borislav Petkov
2014-07-18 14:43 ` Guenter Roeck
2014-07-18 14:56 ` Borislav Petkov
2014-07-18 14:17 ` Lars-Peter Clausen [this message]
2014-07-18 14:24 ` Borislav Petkov
2014-07-18 14:35 ` Joe Perches
2014-07-18 14:49 ` Borislav Petkov
2014-07-18 14:57 ` Joe Perches
2014-07-18 15:06 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C92C86.2030408@metafoo.de \
--to=lars@metafoo.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@suse.de \
--cc=dwalter@google.com \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox