Re: [PATCH v10 2/8] Documentation: bindings: add the Berlin SATA PHY

Sergei Shtylyov
2014-07-18T17:27:29Z

Hello.

On 07/18/2014 04:30 PM, Antoine Ténart wrote:

> The Berlin SATA PHY drives the PHY related to the SATA interface. Add
> the corresponding documentation.

> Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com>
> ---
> .../devicetree/bindings/phy/berlin-sata-phy.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/berlin-sata-phy.txt

> diff --git a/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt
> new file mode 100644
> index 000000000000..88f8c23384c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt
> @@ -0,0 +1,34 @@
> +Berlin SATA PHY
> +---------------
> +
> +Required properties:
> +- compatible: should be "marvell,berlin2q-sata-phy"
> +- address-cells: should be 1
> +- size-cells: should be 0
> +- phy-cells: from the generic PHY bindings, must be 1

It's "#address-cells", "#size-cells", and "#phy-cells".

> +- reg: address and length of the register
> +- clocks: reference to the clock entry
> +
> +Sub-nodes:
> +Each PHY should be represented as a sub-node.

Then "#phy-cells" should also belong to the sub-nodes.

> +
> +Sub-nodes required properties:
> +- reg: the PHY number

WBR, Sergei