From: Sasha Levin <sashal@kernel.org>
To: Nicholas Krause <xerofoify@gmail.com>, gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, mail@beyermatthias.de,
hdegoede@redhat.com, dan.j.williams@intel.com,
valentine.barshak@cogentembedded.com, ming.lei@canonical.com,
michael.opdenacker@free-electrons.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c
Date: Fri, 18 Jul 2014 22:36:07 -0400 [thread overview]
Message-ID: <53C9D997.7000409@kernel.org> (raw)
In-Reply-To: <1405704880-10036-1-git-send-email-xerofoify@gmail.com>
On 07/18/2014 01:34 PM, Nicholas Krause wrote:
> I am removing two fix mes in this file as after dicussing then it seems
> there is no reason to check against Null for usb_device as it can never
> be NULL and this is check is therefore not needed.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Please explain exactly why it's not needed, why it can never be NULL, and
what prevents it from being NULL.
"after dicussing" (do you run spellcheck on your mails?) won't mean anything
to someone looking at this commit in a year.
Your commit message also mentions usb_device which has nothing to do with
your patch.
Thanks,
Sasha
next prev parent reply other threads:[~2014-07-19 2:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 17:34 [PATCH] usb-core: Remove Fix mes in file hcd.c Nicholas Krause
2014-07-18 19:09 ` Alan Stern
2014-07-18 19:55 ` Nick Krause
2014-07-19 2:36 ` Sasha Levin [this message]
2014-07-19 2:45 ` Nick Krause
2014-07-19 2:52 ` Nick Krause
2014-07-23 0:44 ` Sasha Levin
2014-07-23 3:24 ` Nick Krause
2014-07-24 13:07 ` Vlastimil Babka
2014-07-24 16:17 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C9D997.7000409@kernel.org \
--to=sashal@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
--cc=michael.opdenacker@free-electrons.com \
--cc=ming.lei@canonical.com \
--cc=stern@rowland.harvard.edu \
--cc=valentine.barshak@cogentembedded.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).