public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasily Averin <vvs@parallels.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch] fs: umount on symlinlk leaks mnt count
Date: Sun, 20 Jul 2014 09:47:58 +0400	[thread overview]
Message-ID: <53CB580E.6060804@parallels.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Currently umount on symlink blocks following umount:

/vz is separate mount

# ls /vz/ -al | grep test
drwxr-xr-x.  2 root root       4096 Jul 19 01:14 testdir
lrwxrwxrwx.  1 root root         11 Jul 19 01:16 testlink -> /vz/testdir

# umount -l /vz/testlink
umount: /vz/testlink: not mounted (expected)

# lsof /vz
# umount /vz
umount: /vz: device is busy. (unexpected)

Looks like an extra refcount on mnt was taken in mountpoint_last()
Patch below fixes the problem on my test node.

Signed-off-by:	Vasily Averin <vvs@openvz.org>

[-- Attachment #2: diff-umount-symlink-ms --]
[-- Type: text/plain, Size: 328 bytes --]

diff --git a/fs/namei.c b/fs/namei.c
index 985c6f3..0d32a0f 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2305,6 +2305,7 @@ path_mountpoint(int dfd, const char *name, struct path *path, unsigned int flags
 			break;
 		err = mountpoint_last(&nd, path);
 		put_link(&nd, &link, cookie);
+		mntput(link.mnt);
 	}
 out:
 	if (base)

                 reply	other threads:[~2014-07-20  5:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CB580E.6060804@parallels.com \
    --to=vvs@parallels.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox