Re: [PATCH] cleanup include/asm-generic/atomic.h

[Madhavan Srinivasan <maddy@linux.vnet.ibm.com>]

On Tuesday 22 July 2014 05:38 AM, David Rientjes wrote:
> On Tue, 22 Jul 2014, Madhavan Srinivasan wrote:
> 
>> Commit 4b358e2206 "cleanup include/asm-generic/atomic.h" added
>> comments for #else/#endif, but ended up adding same comment
>> "BITS_PER_LONG == 64" on both sides. This patch fixes it.
>>
> 
> It's intentionally like that, it comments the condition for which the 
> #endif is matched.

Ok, will change the else comment. And include/asm-generic/local64.h
also needs a change in comment.

Regards
Maddy

> 
>> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
>> ---
>>  include/asm-generic/atomic-long.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/asm-generic/atomic-long.h b/include/asm-generic/atomic-long.h
>> index b7babf0..a8434c6 100644
>> --- a/include/asm-generic/atomic-long.h
>> +++ b/include/asm-generic/atomic-long.h
>> @@ -253,6 +253,6 @@ static inline long atomic_long_add_unless(atomic_long_t *l, long a, long u)
>>  #define atomic_long_xchg(v, new) \
>>  	(atomic_xchg((atomic_t *)(v), (new)))
>>  
>> -#endif  /*  BITS_PER_LONG == 64  */
>> +#endif  /*  BITS_PER_LONG != 64  */
>>  
>>  #endif  /*  _ASM_GENERIC_ATOMIC_LONG_H  */
>