public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: myungjoo.ham@samsung.com, patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: arizona: Get MICVDD against extcon device
Date: Tue, 22 Jul 2014 14:12:39 +0900	[thread overview]
Message-ID: <53CDF2C7.3070705@samsung.com> (raw)
In-Reply-To: <1405684740-28768-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

On 07/18/2014 08:59 PM, Charles Keepax wrote:
> Previously we would do a regulator get against the main Arizona device
> to obtain the MICVDD regulator. Arizona is an MFD device and normally
> MICVDD will be supplied by one of its children (the arizona-micsupp
> regulator). As devres destruction for the MFD device will run after all
> its children have been destroyed, the regulator will be destroyed before
> devres calls regulator_put. This causes a warning from both the
> destruction of the child node, as the regulator is still open, and from
> the put of the regulator as the regulator device has already been
> destroyed.
> 
> A simple fix here is to get the regulator against the extcon device
> itself such that devres runs when the child is destroyed. This has the
> additional benefit that if for some reason the extcon driver is unloaded
> the regulator reference won't hang around until the MFD is unloaded.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Applied now, Thanks.

Chanwoo Choi


      reply	other threads:[~2014-07-22  5:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18 11:59 [PATCH] extcon: arizona: Get MICVDD against extcon device Charles Keepax
2014-07-22  5:12 ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CDF2C7.3070705@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox