Re: [PATCH v2 1/3] perf/sdt : Listing of SDT markers by perf

Namhyung Kim
2014-07-21T02:38:43Z

Hi Andi,

On Fri, 18 Jul 2014 10:50:45 -0700, Andi Kleen wrote:
> Hemant Kumar <hemant@linux.vnet.ibm.com> writes:
>> +/*
>> + * Finds out the libraries present in a system as shown by the command
>> + * "ldconfig --print-cache". Uses "=>" and '/' to find out the start of a
>> + * dso path.
>> + */
>
> This seems like a hack. How would that handle chroot, containers
> etc. ?

[SNIP]
>> +/*
>> + * Obtain the list of paths from the PATH env variable
>> + */
>
> Same as above. This probably needs to be more configurable to handle
> more ways to find binaries.

Agreed. What about not to be smart? IOW, just let users specify
directories and/or files to be scanned. Maybe we can use it like:

perf list sdt --scan $PATH

or

perf sdt-cache --scan /lib:/lib64

We can add some wrapper or default directory later if needed.

Thanks,
Namhyung