Re: [RFC] perf to ctf converter

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 07/21/2014 08:35 PM, Jiri Olsa wrote:
> On Mon, Jul 21, 2014 at 07:11:51PM +0200, Sebastian Andrzej Siewior wrote:
>
> heya,
> I've  got following build error:
> 
>   CC       util/data-bt.o
> util/data-bt.c: In function ‘add_event_tracepoint_value’:
> util/data-bt.c:293:3: error: implicit declaration of function ‘bt_ctf_event_class_get_field_by_name’ [-Werror=implicit-function-declaration]
>    type = bt_ctf_event_class_get_field_by_name(
>    ^
> util/data-bt.c:293:3: error: nested extern declaration of ‘bt_ctf_event_class_get_field_by_name’ [-Werror=nested-externs]
> util/data-bt.c:293:8: error: assignment makes pointer from integer without a cast [-Werror]
>    type = bt_ctf_event_class_get_field_by_name(
>         ^
> cc1: all warnings being treated as errors
> make[1]: *** [util/data-bt.o] Error 1
> make: *** [all] Error 2
> 
> 
> but I might be missing some of the babeltrace changes, my branch:
>   5805251d8079 Fix: mmap trace read the stream_id from the first packet

Hmm. This function should be there as of commit 2f100782231 in the
master branch. However since my first post and now the babeltrace
source got moved around a little and as a result you have some more
header files.
The function in question is defined in "babeltrace/ctf-ir/event.h" and
included by "babeltrace/ctf-writer/event.h".

> feel free to use/change my commits as you wish ;-)

Thank you.

> 
> I think the best would be to merge your changes with mine
> into some meaningful patchset, before it goes to review

Yeah. I merged some of the fixups back and for the data-bt.c changes,
dunno. Either all my changes as a single patch or merge it back into
yours as it doesn't make sense to post each incremental change.

> I'll check your changes
> 
> thanks,
> jirka
> 
Sebastian