From: "H. Peter Anvin" <hpa@zytor.com>
To: Klemen Jan Enova <klemen.jan.enova@gmail.com>,
linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, x86@kernel.org
Subject: Re: [PATCH] arch: x86: boot: bioscall.S: simplify self-modification of the INT instruction
Date: Tue, 22 Jul 2014 04:25:53 -0700 [thread overview]
Message-ID: <53CE4A41.4020605@zytor.com> (raw)
In-Reply-To: <53CE449C.2090001@gmail.com>
On 07/22/2014 04:01 AM, Klemen Jan Enova wrote:
> At the start of the intcall function, the %al register is compared to
> 0x3f. If it does not equal 0x3f it is equated to it. Instruction flow
> continues in both cases from the label 1. The comparison is therefore
> unneeded.
>
> Testing data is appended.
>
> Signed-off-and-tested-by: Klemen Jan Enova <klemen.jan.enova@gmail.com>
NAK.
This is a performance optimization - the SMC takes a substantial penalty
so the write is avoided if necessary.
Also, 3f is a label, not 0x3f.
-hpa
prev parent reply other threads:[~2014-07-22 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 11:01 [PATCH] arch: x86: boot: bioscall.S: simplify self-modification of the INT instruction Klemen Jan Enova
2014-07-22 11:25 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE4A41.4020605@zytor.com \
--to=hpa@zytor.com \
--cc=klemen.jan.enova@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox