From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Kirill Tkhai <ktkhai@parallels.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
mingo@kernel.org, pjt@google.com
Subject: Re: [PATCH] sched: update last_balance only when actually balanced
Date: Tue, 22 Jul 2014 11:46:39 -0400 [thread overview]
Message-ID: <53CE875F.5040007@redhat.com> (raw)
In-Reply-To: <20140722120445.GB3935@laptop>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/22/2014 08:04 AM, Peter Zijlstra wrote:
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index
>> 45943b2..4f7fee2 100644 --- a/kernel/sched/fair.c +++
>> b/kernel/sched/fair.c @@ -7187,7 +7187,9 @@ static void
>> rebalance_domains(struct rq *rq, enum cpu_idle_type idle) */ idle
>> = idle_cpu(cpu) ? CPU_IDLE : CPU_NOT_IDLE; } - sd->last_balance
>> = jiffies; + /* Only update if we actually balanced. */ + if
>> (continue_balancing) + sd->last_balance = jiffies; interval =
>> get_sd_balance_interval(sd, idle != CPU_IDLE); } if
>> (need_serialize)
>
> Did you actually see any difference with this patch?
>
> The reason I'm asking is that the sched_domains are per cpu, so
> the above assignment is only visible to that particular cpu, not
> other cpus.
It was past 2AM, it may have been a placebo effect :)
Back to the drawing board, to figure out why the load balancing code
is not working quite as expected...
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTzodfAAoJEM553pKExN6DR3oH+wVSYjVu6eV1tzaDLw2xSvSl
rO8hC9GtIf3LX8NVp/UTVkQXt7wWDLcpV4f+AO9+ikB9Dk5YD9wfTF6vhZVrP8GV
Zjpd3HvO/H3RYomyDXLbocjZ97JsXBF7kxRWmYw0kixUIzhdt/sZKGc46aQXPnGy
BfcGcYYbBKeFr9rrYTTvHwN5XVB1ZMZBEWiH/6baXGgZ5V/rTdcZDw0VGXailpbn
eM5j33B9gCE6bYxD1uCrfZXdaO4BORCkiqfncpSVqLnl9k7B9HbY44bcbqht/qHy
B/F/7+imlvAfhwfQAhj8EYomaAT2GI8m6Ab7frxagJURJ1McU3r+2dgkkhsSqP8=
=QnLG
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2014-07-22 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 6:21 [PATCH] sched: update last_balance only when actually balanced Rik van Riel
2014-07-22 12:04 ` Peter Zijlstra
2014-07-22 15:46 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CE875F.5040007@redhat.com \
--to=riel@redhat.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox