Re: [PATCH v2 5/5] i2c: tegra: Remove suspension check

Bastian Hecht
2014-07-17T17:00:41Z

2014-07-17 16:59 GMT+02:00 Thierry Reding <thierry.reding@gmail.com>:
> On Thu, Jul 17, 2014 at 04:48:40PM +0200, Bastian Hecht wrote:
> [...]
>> #ifdef CONFIG_PM_SLEEP
>> -static int tegra_i2c_suspend(struct device *dev)
>> -{
>> - struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
>> -
>> - i2c_lock_adapter(&i2c_dev->adapter);
>> - i2c_dev->is_suspended = true;
>> - i2c_unlock_adapter(&i2c_dev->adapter);
>> -
>> - return 0;
>> -}
>> -
>> static int tegra_i2c_resume(struct device *dev)
>> {
>> struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
>> @@ -842,14 +827,12 @@ static int tegra_i2c_resume(struct device *dev)
>> return ret;
>> }
>>
>> - i2c_dev->is_suspended = false;
>> -
>> i2c_unlock_adapter(&i2c_dev->adapter);
>>
>> return 0;
>> }
>>
>> -static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_suspend, tegra_i2c_resume);
>> +static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_resume);
>
> Shouldn't this be:
>
> static SIMPLE_DEV_OPS(tegra_i2c_pm, NULL, tegra_i2c_resume);
>
> instead?

Oh yes thanks. I made the same mistake in [PATCH 3/5] too.

Thanks,

Bastian

> Thierry