Re: [PATCH v2 5/5] i2c: tegra: Remove suspension check

Thierry Reding
2014-07-17T15:00:06Z

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On Thu, Jul 17, 2014 at 04:48:40PM +0200, Bastian Hecht wrote:
[...]
> #ifdef CONFIG_PM_SLEEP
> -static int tegra_i2c_suspend(struct device *dev)
> -{
> - struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
> -
> - i2c_lock_adapter(&i2c_dev->adapter);
> - i2c_dev->is_suspended = true;
> - i2c_unlock_adapter(&i2c_dev->adapter);
> -
> - return 0;
> -}
> -
> static int tegra_i2c_resume(struct device *dev)
> {
> struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
> @@ -842,14 +827,12 @@ static int tegra_i2c_resume(struct device *dev)
> return ret;
> }
>
> - i2c_dev->is_suspended = false;
> -
> i2c_unlock_adapter(&i2c_dev->adapter);
>
> return 0;
> }
>
> -static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_suspend, tegra_i2c_resume);
> +static SIMPLE_DEV_PM_OPS(tegra_i2c_pm, tegra_i2c_resume);

Shouldn't this be:

static SIMPLE_DEV_OPS(tegra_i2c_pm, NULL, tegra_i2c_resume);

instead?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]