From: Sasha Levin <sashal@kernel.org>
To: Nick Krause <xerofoify@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
mail@beyermatthias.de, hdegoede@redhat.com,
dan.j.williams@intel.com, valentine.barshak@cogentembedded.com,
Ming Lei <ming.lei@canonical.com>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c
Date: Tue, 22 Jul 2014 20:44:00 -0400 [thread overview]
Message-ID: <53CF0550.2040309@kernel.org> (raw)
In-Reply-To: <CAPDOMVg1Ga1wQserL=P9cmFgtPM+XLNFpY+t45QV0GvPLbTmwA@mail.gmail.com>
On 07/18/2014 10:52 PM, Nick Krause wrote:
> On Fri, Jul 18, 2014 at 10:45 PM, Nick Krause <xerofoify@gmail.com> wrote:
>> Sorry didn't run spell check. I will resend this patch with the
>> correct information
>> as needed. Thanks for the advice, Sasha.
>>
>> Cheers Nick
>>
>> On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin <sashal@kernel.org> wrote:
>>> On 07/18/2014 01:34 PM, Nicholas Krause wrote:
>>>> I am removing two fix mes in this file as after dicussing then it seems
>>>> there is no reason to check against Null for usb_device as it can never
>>>> be NULL and this is check is therefore not needed.
>>>>
>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>>
>>> Please explain exactly why it's not needed, why it can never be NULL, and
>>> what prevents it from being NULL.
>>>
>>> "after dicussing" (do you run spellcheck on your mails?) won't mean anything
>>> to someone looking at this commit in a year.
>>>
>>> Your commit message also mentions usb_device which has nothing to do with
>>> your patch.
>>>
>>>
>>> Thanks,
>>> Sasha
>
> Sasha ,
> Greg seems to have signed it off.
> Cheers Nick
Greg?
Even if the patch is correct (and I'm not saying it is) the commit message is way off.
Thanks,
Sasha
next prev parent reply other threads:[~2014-07-23 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 17:34 [PATCH] usb-core: Remove Fix mes in file hcd.c Nicholas Krause
2014-07-18 19:09 ` Alan Stern
2014-07-18 19:55 ` Nick Krause
2014-07-19 2:36 ` Sasha Levin
2014-07-19 2:45 ` Nick Krause
2014-07-19 2:52 ` Nick Krause
2014-07-23 0:44 ` Sasha Levin [this message]
2014-07-23 3:24 ` Nick Krause
2014-07-24 13:07 ` Vlastimil Babka
2014-07-24 16:17 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CF0550.2040309@kernel.org \
--to=sashal@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
--cc=michael.opdenacker@free-electrons.com \
--cc=ming.lei@canonical.com \
--cc=stern@rowland.harvard.edu \
--cc=valentine.barshak@cogentembedded.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).